Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on the user allocation in ihfft #159

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Rely on the user allocation in ihfft #159

merged 1 commit into from
Oct 9, 2024

Conversation

tpadioleau
Copy link
Collaborator

Are we sure we want to discard the user allocation ?

@tpadioleau tpadioleau self-assigned this Oct 8, 2024
@tpadioleau
Copy link
Collaborator Author

linked to #158

yasahi-hpc
yasahi-hpc approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@yasahi-hpc yasahi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
May be less performant than the original implementation?

@yasahi-hpc yasahi-hpc merged commit c8ba790 into kokkos:main Oct 9, 2024
19 of 20 checks passed
@tpadioleau tpadioleau deleted the fix-output-view-in-ihfft branch October 9, 2024 07:00
@tpadioleau
Copy link
Collaborator Author

LGTM. May be less performant than the original implementation?

For now yes, I think the conjugate operation could be executed in-place ? We could get rid of the out_conj array.

@yasahi-hpc
Copy link
Collaborator

LGTM. May be less performant than the original implementation?

For now yes, I think the conjugate operation could be executed in-place ? We could get rid of the out_conj array.

For this use case, we can make it in-place. For hfft with real input (not implemented yet), I need an out-place version of conjugate since it involves the data type conversion from real to complex. For this, I need to implement a helper to define a complex typed View from real typed View, like

View<double ***> -> View<Kokkos::complex<double> ***>

@tpadioleau
Copy link
Collaborator Author

I see I agree

@yasahi-hpc yasahi-hpc added enhancement New feature or request cleanup labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasahi-hpc yasahi-hpc yasahi-hpc approved these changes

Assignees

@tpadioleau tpadioleau

Labels
cleanup enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpadioleau @yasahi-hpc