Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass output views by const ref #161

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Pass output views by const ref #161

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c22a2a
Pass output views by const ref
tpadioleau Oct 9, 2024
a54a20b
Update accordingly the documentation
tpadioleau Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions fft/src/KokkosFFT_Transform.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ namespace KokkosFFT {
/// nullopt)
template <typename ExecutionSpace, typename InViewType, typename OutViewType>
void fft(const ExecutionSpace& exec_space, const InViewType& in,
OutViewType& out,
const OutViewType& out,
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
int axis = -1, std::optional<std::size_t> n = std::nullopt) {
static_assert(
Expand Down Expand Up @@ -159,7 +159,7 @@ void fft(const ExecutionSpace& exec_space, const InViewType& in,
/// nullopt)
template <typename ExecutionSpace, typename InViewType, typename OutViewType>
void ifft(const ExecutionSpace& exec_space, const InViewType& in,
OutViewType& out,
const OutViewType& out,
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
int axis = -1, std::optional<std::size_t> n = std::nullopt) {
static_assert(
Expand Down Expand Up @@ -189,7 +189,7 @@ void ifft(const ExecutionSpace& exec_space, const InViewType& in,
/// nullopt)
template <typename ExecutionSpace, typename InViewType, typename OutViewType>
void rfft(const ExecutionSpace& exec_space, const InViewType& in,
OutViewType& out,
const OutViewType& out,
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
int axis = -1, std::optional<std::size_t> n = std::nullopt) {
static_assert(
Expand Down Expand Up @@ -225,7 +225,7 @@ void rfft(const ExecutionSpace& exec_space, const InViewType& in,
/// nullopt)
template <typename ExecutionSpace, typename InViewType, typename OutViewType>
void irfft(const ExecutionSpace& exec_space, const InViewType& in,
OutViewType& out,
const OutViewType& out,
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
int axis = -1, std::optional<std::size_t> n = std::nullopt) {
static_assert(
Expand Down Expand Up @@ -262,7 +262,7 @@ void irfft(const ExecutionSpace& exec_space, const InViewType& in,
/// nullopt)
template <typename ExecutionSpace, typename InViewType, typename OutViewType>
void hfft(const ExecutionSpace& exec_space, const InViewType& in,
OutViewType& out,
const OutViewType& out,
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
int axis = -1, std::optional<std::size_t> n = std::nullopt) {
static_assert(
Expand Down Expand Up @@ -306,7 +306,7 @@ void hfft(const ExecutionSpace& exec_space, const InViewType& in,
/// nullopt)
template <typename ExecutionSpace, typename InViewType, typename OutViewType>
void ihfft(const ExecutionSpace& exec_space, const InViewType& in,
OutViewType& out,
const OutViewType& out,
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
int axis = -1, std::optional<std::size_t> n = std::nullopt) {
static_assert(
Expand Down Expand Up @@ -347,7 +347,7 @@ void ihfft(const ExecutionSpace& exec_space, const InViewType& in,
/// \param s [in] Shape of the transformed axis of the output (default, {})
template <typename ExecutionSpace, typename InViewType, typename OutViewType>
void fft2(const ExecutionSpace& exec_space, const InViewType& in,
OutViewType& out,
const OutViewType& out,
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
axis_type<2> axes = {-2, -1}, shape_type<2> s = {}) {
static_assert(
Expand Down Expand Up @@ -376,7 +376,7 @@ void fft2(const ExecutionSpace& exec_space, const InViewType& in,
/// \param s [in] Shape of the transformed axis of the output (default, {})
template <typename ExecutionSpace, typename InViewType, typename OutViewType>
void ifft2(const ExecutionSpace& exec_space, const InViewType& in,
OutViewType& out,
const OutViewType& out,
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
axis_type<2> axes = {-2, -1}, shape_type<2> s = {}) {
static_assert(
Expand Down Expand Up @@ -406,7 +406,7 @@ void ifft2(const ExecutionSpace& exec_space, const InViewType& in,
/// \param s [in] Shape of the transformed axis of the output (default, {})
template <typename ExecutionSpace, typename InViewType, typename OutViewType>
void rfft2(const ExecutionSpace& exec_space, const InViewType& in,
OutViewType& out,
const OutViewType& out,
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
axis_type<2> axes = {-2, -1}, shape_type<2> s = {}) {
static_assert(
Expand Down Expand Up @@ -442,7 +442,7 @@ void rfft2(const ExecutionSpace& exec_space, const InViewType& in,
/// \param s [in] Shape of the transformed axis of the output (default, {})
template <typename ExecutionSpace, typename InViewType, typename OutViewType>
void irfft2(const ExecutionSpace& exec_space, const InViewType& in,
OutViewType& out,
const OutViewType& out,
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
axis_type<2> axes = {-2, -1}, shape_type<2> s = {}) {
static_assert(
Expand Down Expand Up @@ -486,7 +486,8 @@ template <typename ExecutionSpace, typename InViewType, typename OutViewType,
std::size_t DIM = InViewType::rank()>
#endif
void fftn(
const ExecutionSpace& exec_space, const InViewType& in, OutViewType& out,
const ExecutionSpace& exec_space, const InViewType& in,
const OutViewType& out,
axis_type<DIM> axes =
KokkosFFT::Impl::index_sequence<int, DIM, -static_cast<int>(DIM)>(),
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
Expand Down Expand Up @@ -526,7 +527,8 @@ template <typename ExecutionSpace, typename InViewType, typename OutViewType,
std::size_t DIM = InViewType::rank()>
#endif
void ifftn(
const ExecutionSpace& exec_space, const InViewType& in, OutViewType& out,
const ExecutionSpace& exec_space, const InViewType& in,
const OutViewType& out,
axis_type<DIM> axes =
KokkosFFT::Impl::index_sequence<int, DIM, -static_cast<int>(DIM)>(),
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
Expand Down Expand Up @@ -568,7 +570,8 @@ template <typename ExecutionSpace, typename InViewType, typename OutViewType,
std::size_t DIM = InViewType::rank()>
#endif
void rfftn(
const ExecutionSpace& exec_space, const InViewType& in, OutViewType& out,
const ExecutionSpace& exec_space, const InViewType& in,
const OutViewType& out,
axis_type<DIM> axes =
KokkosFFT::Impl::index_sequence<int, DIM, -static_cast<int>(DIM)>(),
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
Expand Down Expand Up @@ -616,7 +619,8 @@ template <typename ExecutionSpace, typename InViewType, typename OutViewType,
std::size_t DIM = InViewType::rank()>
#endif
void irfftn(
const ExecutionSpace& exec_space, const InViewType& in, OutViewType& out,
const ExecutionSpace& exec_space, const InViewType& in,
const OutViewType& out,
axis_type<DIM> axes =
KokkosFFT::Impl::index_sequence<int, DIM, -static_cast<int>(DIM)>(),
KokkosFFT::Normalization norm = KokkosFFT::Normalization::backward,
Expand Down
Loading