Apply to_array helper #171
Conversation
Remove unnecessary variadic integers Co-authored-by: Damien L-G <dalg24+github@gmail.com>
|
We may need a newer version of Kokkos for nicer tests. Should we update Kokkos to 4.4 and update docs accordingly? |
| // [TO DO] Need to update Kokkos version for compile time test | ||
| // GTEST_SKIP() << "Skipping ToArray::rvalue compile time test"; | ||
| // static_assert(KokkosFFT::Impl::to_array(std::array{1, 2}) == | ||
| // Kokkos::Array{1, 2}); |
There was a problem hiding this comment.
If you want, you can already implement the test using the comparison operator inside ifdef based on the version of Kokkos ?
There was a problem hiding this comment.
If you are fine, I would like to keep it in comments since we do not test that in CI for the moment. Though, I am pretty sure it works at least with Kokkos v.4.4.1
There was a problem hiding this comment.
Yes I am ok with that. One question though, how do we keep track that we will need to update this snippet when we increase the minimum version of Kokkos ?
There was a problem hiding this comment.
What about tracking in an issue?
There was a problem hiding this comment.
I am not really confident on remembering that there is actually an issue about this when we bump the minimum version. We can try.
Improves #170
This PR aims at introducing
to_arrayhelper which is used inTransposefunctions.For the compile time testing, we need a newer version of Kokkos.