Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent IndexType #173

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix inconsistent IndexType #173

merged 1 commit into from
Oct 14, 2024

Conversation

tpadioleau
Copy link
Collaborator

An alternative fix is to use IndexType<int>

@tpadioleau tpadioleau self-assigned this Oct 13, 2024
yasahi-hpc
yasahi-hpc approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@yasahi-hpc yasahi-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will merge this

@yasahi-hpc yasahi-hpc merged commit 647f235 into kokkos:main Oct 14, 2024
19 of 20 checks passed
@tpadioleau tpadioleau deleted the inconsistent-indextype branch October 14, 2024 06:17
@yasahi-hpc yasahi-hpc added enhancement New feature or request cleanup labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasahi-hpc yasahi-hpc yasahi-hpc approved these changes

Assignees

@tpadioleau tpadioleau

Labels
cleanup enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpadioleau @yasahi-hpc