feat(KONFLUX-2547): Make it possible to configure BuildPipelineSelector #1111

jhutar · 2024-04-05T11:52:35Z

Description

Make it possible to configure BuildPipelineSelector

Issue ticket number and link

https://issues.redhat.com/browse/KONFLUX-2547

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Locally against Stage and will run a CI test I guess.

cmd/loadTests.go

…ci/e2e-tests#1111

naftalysh · 2024-04-08T13:32:44Z

/test ?

openshift-ci · 2024-04-08T13:32:48Z

@naftalysh: The following commands are available to trigger required jobs:

/test images
/test load-test-ci-100u-1t
/test load-test-ci-10u-10t
/test load-test-ci-10u-10t-go
/test load-test-ci-10u-10t-java
/test load-test-ci-10u-10t-nodejs
/test load-test-ci-10u-10t-python
/test load-test-ci-10u-10t-quarkus
/test load-test-ci-1u-100t
/test load-test-ci-20u-5t
/test load-test-ci-2u-50t
/test load-test-ci-50u-2t
/test load-test-ci-5u-20t
/test load-test-ci-max-concurrency-basic-tekton-tuned
/test load-test-ci-poc
/test load-test-ci-tekton-tuning-base
/test load-test-ci-tekton-tuning-tuned
/test max-concurrency-advanced
/test max-concurrency-basic
/test redhat-appstudio-e2e

Use /test all to run the following jobs that were automatically triggered:

pull-ci-redhat-appstudio-e2e-tests-main-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

naftalysh · 2024-04-08T13:32:59Z

/test load-test-ci-10u-10t

naftalysh · 2024-04-08T13:45:00Z

Looks good
Just ran the CI test to verify success (load-test-ci-10u-10t) ..

naftalysh

We can change the below line -
return fmt.Errorf("error deleting build pipeline selector %d from %s: %v", i, f.UserNamespace, err)

With
return fmt.Errorf("error deleting build pipeline selector %s from %s: %v", bps.Name, f.UserNamespace, err)

jhutar · 2024-04-09T10:25:26Z

We can change the below line - return fmt.Errorf("error deleting build pipeline selector %d from %s: %v", i, f.UserNamespace, err)

With return fmt.Errorf("error deleting build pipeline selector %s from %s: %v", bps.Name, f.UserNamespace, err)

Hello Naftaly. Feedback incorporated. Please take a look now.

naftalysh

return fmt.Errorf("error deleting build pipeline selector %d from %s: %v", bps.Name, f.UserNamespace, err)

Should be replaced by
return fmt.Errorf("error deleting build pipeline selector %s from %s: %v", bps.Name, f.UserNamespace, err)

That's why you get a lint error

naftalysh · 2024-04-11T13:07:24Z

/test load-test-ci-10u-10t

jhutar · 2024-04-12T14:26:29Z

/test load-test-ci-10u-10t

naftalysh · 2024-04-14T09:22:43Z

Hi @jhutar
load-test-ci-10u-10t has failed
I think you already tested it on stage
Let's wait until load-test-ci-10u-10t passes

jhutar · 2024-04-15T15:03:39Z

/test load-test-ci-10u-10t

jhutar · 2024-04-16T06:20:08Z

/test load-test-ci-10u-10t

…ci/e2e-tests#1111

jhutar · 2024-04-17T18:25:56Z

/test load-test-ci-10u-10t

jhutar · 2024-04-18T06:02:10Z

/test load-test-ci-10u-10t

jhutar · 2024-04-18T10:41:07Z

/test load-test-ci-10u-10t

jhutar · 2024-05-01T06:25:11Z

/test load-test-ci-10u-10t

…ci/e2e-tests#1111

openshift-ci · 2024-05-03T07:27:17Z

@jhutar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
Gathering artifacts ...
Unable to connect to the server: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"k8s.io/test-infra/prow/entrypoint/run.go:84","func":"k8s.io/test-infra/prow/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-04-15T21:22:46Z"}
Link to step on registry info site: https://steps.ci.openshift.org/reference/gather-extra
Link to job on registry info site: https://steps.ci.openshift.org/job?org=redhat-appstudio&repo=e2e-tests&branch=main&test=load-test-ci-10u-10t
�[36mINFO�[0m[2024-04-15T21:27:50Z] Reporting job state 'failed' with reason 'executing_graph:step_failed:utilizing_lease:executing_test:executing_multi_stage_test'
name: ci-op-79gg03bg-0d849
level=error msg= status code: 403, request id: 26113a37-1871-48f0-9adb-bf19024f4e54, compute[0].platform.aws: Internal error: error listing instance types: fetching instance types: UnauthorizedOperation: You are not authorized to perform this operation. User: arn:aws:iam::992382442726:user/prow-service-account is not authorized to perform: ec2:DescribeInstanceTypes with an explicit deny in a service control policy
level=error msg= status code: 403, request id: 27cab43f-495b-429a-9b24-9b3e2baf7783]
{"component":"entrypoint","error":"wrapped process failed: exit status 3","file":"k8s.io/test-infra/prow/entrypoint/run.go:84","func":"k8s.io/test-infra/prow/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-04-12T14:35:45Z"}
Link to job on registry info site: https://steps.ci.openshift.org/job?org=redhat-appstudio&repo=e2e-tests&branch=main&test=load-test-ci-10u-10t, "load-test-ci-10u-10t" post steps failed: "load-test-ci-10u-10t" pod "load-test-ci-10u-10t-redhat-appstudio-gather" failed: could not watch pod: the pod ci-op-79gg03bg/load-test-ci-10u-10t-redhat-appstudio-gather failed after 8s (failed containers: test): ContainerFailed one or more containers exited
found: /tmp/kubeconfig-3438120358
W0412 14:35:53.819489 916 loader.go:222] Config not found: /tmp/kubeconfig-3438120358
W0412 14:35:53.837478 921 loader.go:222] Config not found: /tmp/kubeconfig-3438120358
W0412 14:35:53.848722 957 loader.go:222] Config not found: /tmp/kubeconfig-3438120358
W0412 14:35:53.861130 965 loader.go:222] Config not found: /tmp/kubeconfig-3438120358
W0412 14:35:53.865076 990 loader.go:222] Config not found: /tmp/kubeconfig-3438120358
W0412 14:35:53.865675 945 loader.go:222] Config not found: /tmp/kubeconfig-3438120358
W0412 14:35:53.873962 1015 loader.go:222] Config not found: /tmp/kubeconfig-3438120358
W0412 14:35:53.877356 1049 loader.go:222] Config not found: /tmp/kubeconfig-3438120358
W0412 14:35:53.879118 996 loader.go:222] Config not found: /tmp/kubeconfig-3438120358
W0412 14:35:53.881370 1035 loader.go:222] Config not found: /tmp/kubeconfig-3438120358
W0412 14:35:53.890054 1025 loader.go:222] Config not found: /tmp/kubeconfig-3438120358
W0412 14:35:53.894500 1053 loader.go:222] Config not found: /tmp/kubeconfig-3438120358
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"k8s.io/test-infra/prow/entrypoint/run.go:84","func":"k8s.io/test-infra/prow/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-04-12T14:35:53Z"}
�[36mINFO�[0m[2024-04-12T15:05:15Z] Reporting job state 'failed' with reason 'executing_graph:step_failed:utilizing_lease:executing_test:executing_multi_stage_test'
apiVersion: v1
metadata:
name: ci-op-jj3f5445-0d849
uayio-pull-through-cache-us-east-1-ci.apps.ci.l2s4.p1.openshiftapps.com
source: quay.io
level=info msg=Credentials loaded from the "default" profile in file "/var/run/secrets/ci.openshift.io/cluster-profile/.awscred"
level=error msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create install config: [controlPlane.platform.aws: Internal error: error listing instance types: fetching instance types: UnauthorizedOperation: You are not authorized to perform this operation. User: arn:aws:iam::992382442726:user/prow-service-account is not authorized to perform: ec2:DescribeInstanceTypes with an explicit deny in a service control policy
level=error msg= status code: 403, request id: c010b1db-d6fa-424e-bd44-7a06f86020b5, compute[0].platform.aws: Internal error: error listing instance types: fetching instance types: UnauthorizedOperation: You are not authorized to perform this operation. User: arn:aws:iam::992382442726:user/prow-service-account is not authorized to perform: ec2:DescribeInstanceTypes with an explicit deny in a service control policy
level=error msg= status code: 403, request id: a917d8fc-6016-4368-9010-586eddb1d95b]
Create manifests exit code: 3
Tear down the backgroup process of copying kube config
Setup phase finished, prepare env for next steps
Copying log bundle...
Removing REDACTED info from log...
Unsupported cluster type 'aws' to collect machine IDs
Copying required artifacts to shared dir
cp: cannot stat '/tmp/installer/auth/kubeconfig': No such file or directory
cp: cannot stat '/tmp/installer/auth/kubeadmin-password': No such file or directory
cp: cannot stat '/tmp/installer/metadata.json': No such file or directory
{"component":"entrypoint","error":"wrapped process failed: exit status 3","file":"k8s.io/test-infra/prow/entrypoint/run.go:84","func":"k8s.io/test-infra/prow/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-04-11T13:11:39Z"}
error: failed to execute wrapped command: exit status 3
Link to step on registry info site: https://steps.ci.openshift.org/reference/ipi-install-install
Link to job on registry info site: https://steps.ci.openshift.org/job?org=redhat-appstudio&repo=e2e-tests&branch=main&test=load-test-ci-10u-10t, "load-test-ci-10u-10t" post steps failed: "load-test-ci-10u-10t" pod "load-test-ci-10u-10t-redhat-appstudio-gather" failed: could not watch pod: the pod ci-op-jj3f5445/load-test-ci-10u-10t-redhat-appstudio-gather failed after 16s (failed containers: test): ContainerFailed one or more containers exited
insecure-skip-tls-verify --request-timeout=5s get clusterregistrars.singapore.open-cluster-management.io -o json
W0411 13:11:56.072526 890 loader.go:222] Config not found: /tmp/kubeconfig-3266694923
W0411 13:11:56.105118 902 loader.go:222] Config not found: /tmp/kubeconfig-3266694923
W0411 13:11:56.105365 878 loader.go:222] Config not found: /tmp/kubeconfig-3266694923
oc --insecure-skip-tls-verify --request-timeout=5s get gitopsservices.pipelines.openshift.io -o json
W0411 13:11:56.131472 843 loader.go:222] Config not found: /tmp/kubeconfig-3266694923
W0411 13:11:56.136272 915 loader.go:222] Config not found: /tmp/kubeconfig-3266694923
W0411 13:11:56.139968 935 loader.go:222] Config not found: /tmp/kubeconfig-3266694923
W0411 13:11:56.153246 906 loader.go:222] Config not found: /tmp/kubeconfig-3266694923
W0411 13:11:56.221451 946 loader.go:222] Config not found: /tmp/kubeconfig-3266694923
W0411 13:11:56.232807 970 loader.go:222] Config not found: /tmp/kubeconfig-3266694923
W0411 13:11:56.235817 957 loader.go:222] Config not found: /tmp/kubeconfig-3266694923
W0411 13:11:56.245425 976 loader.go:222] Config not found: /tmp/kubeconfig-3266694923
error: default cluster has no server defined
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"k8s.io/test-infra/prow/entrypoint/run.go:84","func":"k8s.io/test-infra/prow/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-04-11T13:11:56Z"}
error: failed to execute wrapped command: exit status 1
Link to step on registry info site: https://steps.ci.openshift.org/reference/redhat-appstudio-gather
Link to job on registry info site: https://steps.ci.openshift.org/job?org=redhat-appstudio&repo=e2e-tests&branch=main&test=load-test-ci-10u-10t]
�[36mINFO�[0m[2024-04-11T13:12:53Z] Reporting job state 'failed' with reason 'executing_graph:step_failed:utilizing_lease:executing_test:executing_multi_stage_test'

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Changes in wait for branch to appear discussed with Pavel Sturc in https://redhat-internal.slack.com/archives/C02FANRBZQD/p1713856264091809

…pear

Expose accurate resources metrics into load-tests.json (metrics that overcome the time-skew issue) Signed-Off-By: Naftaly Shprai <naftalysh@gmail.com>

sonarcloud · 2024-05-03T09:13:22Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

openshift-merge-robot · 2024-05-16T00:17:03Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jhutar · 2024-05-16T09:14:09Z

Obsoleted by #1163

openshift-ci bot requested review from flacatus and tisutisu April 5, 2024 11:52

github-actions bot added the 1-5 min label Apr 5, 2024

jhutar force-pushed the fix15 branch from 759dac4 to 4988249 Compare April 5, 2024 14:04

github-advanced-security bot found potential problems Apr 5, 2024

View reviewed changes

cmd/loadTests.go Fixed Show fixed Hide fixed

jhutar force-pushed the fix15 branch from 4988249 to 86dc0f3 Compare April 8, 2024 07:27

github-advanced-security bot found potential problems Apr 8, 2024

View reviewed changes

cmd/loadTests.go Fixed Show fixed Hide fixed

jhutar force-pushed the fix15 branch from 86dc0f3 to 59c6850 Compare April 8, 2024 10:02

jhutar added a commit to jhutar/release that referenced this pull request Apr 8, 2024

temp(KONFLUX-2547): PR with support fr that still not merged konflux-…

9a899c6

…ci/e2e-tests#1111

naftalysh reviewed Apr 8, 2024

View reviewed changes

jhutar force-pushed the fix15 branch from 36f031e to 2cb5070 Compare April 9, 2024 10:14

naftalysh previously requested changes Apr 10, 2024

View reviewed changes

jhutar force-pushed the fix15 branch from 2cb5070 to 1075c35 Compare April 11, 2024 10:59

jhutar force-pushed the fix15 branch from 1075c35 to c97ed47 Compare April 16, 2024 06:19

jhutar added a commit to jhutar/release that referenced this pull request Apr 16, 2024

temp(KONFLUX-2547): PR with support fr that still not merged konflux-…

5354d73

…ci/e2e-tests#1111

jhutar added a commit to jhutar/release that referenced this pull request Apr 16, 2024

temp(KONFLUX-2547): PR with support fr that still not merged konflux-…

32f2626

…ci/e2e-tests#1111

jhutar force-pushed the fix15 branch from c97ed47 to bf0c0e6 Compare April 18, 2024 10:38

openshift-merge-robot added the needs-rebase label May 2, 2024

jhutar added a commit to jhutar/release that referenced this pull request May 3, 2024

temp(KONFLUX-2547): PR with support fr that still not merged konflux-…

b707f15

…ci/e2e-tests#1111

jhutar force-pushed the fix15 branch from 4253e75 to 977a0e0 Compare May 3, 2024 06:59

openshift-merge-robot removed the needs-rebase label May 3, 2024

github-actions bot added 10-15 min and removed 5-10 min labels May 3, 2024

jhutar mentioned this pull request May 3, 2024

feat(KONFLUX-2603): Make it possible to create a template from a repo #1133

Closed

jhutar force-pushed the fix15 branch from 977a0e0 to 76a8a34 Compare May 3, 2024 08:38

github-actions bot added 5-10 min and removed 10-15 min labels May 3, 2024

jhutar force-pushed the fix15 branch from 76a8a34 to 3ffd061 Compare May 3, 2024 08:40

github-actions bot added 10-15 min and removed 5-10 min labels May 3, 2024

jhutar and others added 7 commits May 3, 2024 11:12

feat(KONFLUX-2603): Make it possible to create a template from a repo

c976f2f

Changes in wait for branch to appear discussed with Pavel Sturc in https://redhat-internal.slack.com/archives/C02FANRBZQD/p1713856264091809

fix: Do not spam output if we are just waiting for a deployment to ap…

9d8b8d9

…pear

feat(KONFLUX-2547): Make it possible to configure BuildPipelineSelector

82fab56

debug: Setup with secrets for Build and App services

45bce46

feat: Make it possible to set COMPONENT_REPO_REVISION in SCENARIO config

9d7c713

fix(KONFLUX-870): KONFLUX-870-Expose-accurate-resources-metrics

04defb3

Expose accurate resources metrics into load-tests.json (metrics that overcome the time-skew issue) Signed-Off-By: Naftaly Shprai <naftalysh@gmail.com>

fix: Return back pieces dropped from previous merge

71646ae

jhutar force-pushed the fix15 branch from 3ffd061 to 71646ae Compare May 3, 2024 09:13

github-actions bot added 5-10 min and removed 10-15 min labels May 3, 2024

openshift-merge-robot added the needs-rebase label May 16, 2024

jhutar closed this May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(KONFLUX-2547): Make it possible to configure BuildPipelineSelector #1111

feat(KONFLUX-2547): Make it possible to configure BuildPipelineSelector #1111

jhutar commented Apr 5, 2024

naftalysh commented Apr 8, 2024

openshift-ci bot commented Apr 8, 2024

naftalysh commented Apr 8, 2024

naftalysh commented Apr 8, 2024

naftalysh left a comment

jhutar commented Apr 9, 2024

naftalysh left a comment •

edited

Loading

naftalysh commented Apr 11, 2024

jhutar commented Apr 12, 2024

naftalysh commented Apr 14, 2024 •

edited

Loading

jhutar commented Apr 15, 2024

jhutar commented Apr 16, 2024

jhutar commented Apr 17, 2024

jhutar commented Apr 18, 2024

jhutar commented Apr 18, 2024

jhutar commented May 1, 2024

openshift-ci bot commented May 3, 2024 •

edited

Loading

sonarcloud bot commented May 3, 2024

openshift-merge-robot commented May 16, 2024

jhutar commented May 16, 2024

feat(KONFLUX-2547): Make it possible to configure BuildPipelineSelector #1111

feat(KONFLUX-2547): Make it possible to configure BuildPipelineSelector #1111

Conversation

jhutar commented Apr 5, 2024

Description

Issue ticket number and link

Type of change

How Has This Been Tested?

naftalysh commented Apr 8, 2024

openshift-ci bot commented Apr 8, 2024

naftalysh commented Apr 8, 2024

naftalysh commented Apr 8, 2024

naftalysh left a comment

Choose a reason for hiding this comment

jhutar commented Apr 9, 2024

naftalysh left a comment • edited Loading

Choose a reason for hiding this comment

naftalysh commented Apr 11, 2024

jhutar commented Apr 12, 2024

naftalysh commented Apr 14, 2024 • edited Loading

jhutar commented Apr 15, 2024

jhutar commented Apr 16, 2024

jhutar commented Apr 17, 2024

jhutar commented Apr 18, 2024

jhutar commented Apr 18, 2024

jhutar commented May 1, 2024

openshift-ci bot commented May 3, 2024 • edited Loading

sonarcloud bot commented May 3, 2024

Quality Gate passed

openshift-merge-robot commented May 16, 2024

jhutar commented May 16, 2024

naftalysh left a comment •

edited

Loading

naftalysh commented Apr 14, 2024 •

edited

Loading

openshift-ci bot commented May 3, 2024 •

edited

Loading