change condition of using node export system. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original condition of using node export system causes error when used with QUnit.
| if (typeof module !== 'undefined' && module.exports) { | ||
| exports = module.exports = JsDiff; | ||
| } | ||
| exports.JsDiff = JsDiff; |
There was a problem hiding this comment.
This materially changes the export. Why creating the named, circular export?
There was a problem hiding this comment.
I found this pattern at underscore.js export pattern
Add support for CommonJS implementations that do not support modules.exports. mention about this code.
There was a problem hiding this comment.
Having gone this long without anyone complaining (and my sense is that node has won out), I'd rather not add this API as it effectively makes the API conditional on the environment. If you remove this line I'm fine merging the rest.
There was a problem hiding this comment.
okay I'll fix that line~ :D
kpdecker
added a commit
that referenced
this pull request
Dec 26, 2014
change condition of using node export system.
|
Released in 1.2.1 |
|
I am proud of contributing your repo.. thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original condition of using node export system causes error when used with QUnit.
QUnit's 'module' Function is defined globaly.
So current export logic is malfunctioning.
I change that logic more precise.