-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to newer versions of TypeScript and TSLint, add --fix option #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 1 comm
@@ -21,10 +21,6 @@ | |||
"avoid-escape", | |||
"jsx-double" | |||
], | |||
"no-unused-variable": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you remove this rule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is deprecated in TSLint. You're prompted to start using the compilerOption --noUnusedParameters and the like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh I see. Okay then, it would be nice to find a substitute for this rule in future...
Thanks for your contribution :) There is 1 comment and I think we can get this merged. |
@emilniklas Thanks, awesome work! I will release a new package in few minutes. |
Hmm, I hope that putting |
@krzkaczor Yarn's lockfile should always be included regardless. Yarn doesn't use it for transient dependencies anyway. Check this out for details :) |
@emilniklas That's interesting. I was pretty sure that it does yarnpkg/yarn#1067 I will just |
Title speaks for itself. Also, I added a yarn.lock file simply because many people use it, like myself, and it's non destructive for NPM users.