Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to newer versions of TypeScript and TSLint, add --fix option #3

Merged
merged 3 commits into from
Jan 18, 2017

Conversation

emilniklas
Copy link
Contributor

Title speaks for itself. Also, I added a yarn.lock file simply because many people use it, like myself, and it's non destructive for NPM users.

Copy link
Owner

@krzkaczor krzkaczor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 1 comm

@@ -21,10 +21,6 @@
"avoid-escape",
"jsx-double"
],
"no-unused-variable": [
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you remove this rule?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is deprecated in TSLint. You're prompted to start using the compilerOption --noUnusedParameters and the like.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh I see. Okay then, it would be nice to find a substitute for this rule in future...

@krzkaczor
Copy link
Owner

Thanks for your contribution :) There is 1 comment and I think we can get this merged.

@krzkaczor krzkaczor merged commit 68f3cdc into krzkaczor:master Jan 18, 2017
@krzkaczor
Copy link
Owner

@emilniklas Thanks, awesome work! I will release a new package in few minutes.

@krzkaczor
Copy link
Owner

Hmm, I hope that putting yarn.lock in this project won't produce any problems. It should be okay since users shouldn't have another tslint in theirs projects dependencies.

@emilniklas
Copy link
Contributor Author

@krzkaczor Yarn's lockfile should always be included regardless. Yarn doesn't use it for transient dependencies anyway. Check this out for details :)

@krzkaczor
Copy link
Owner

@emilniklas That's interesting. I was pretty sure that it does yarnpkg/yarn#1067 I will just npmignore it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants