Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ray[serve] to version 1.5.0, allowing kfserving to be installed on python3.9 #1772

Merged
merged 3 commits into from
Aug 22, 2021

Conversation

Lewiky
Copy link
Contributor

@Lewiky Lewiky commented Aug 19, 2021

What this PR does / why we need it:

kfserving currently cannot be installed on python versions >3.7 due to a hard dependency on ray[serve]==1.3.0 which itself requires python==3.7.

This PR updates the pinned ray version to 1.5.0 which does support newer python versions, and makes the necessary API changes.

Which issue(s) this PR fixes:
Fixes #1753

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Adds python3.9 support to KFServing.

@google-cla
Copy link

google-cla bot commented Aug 19, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@aws-kf-ci-bot
Copy link
Contributor

Hi @Lewiky. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuzisun
Copy link
Member

yuzisun commented Aug 19, 2021

/ok-to-test

@yuzisun
Copy link
Member

yuzisun commented Aug 22, 2021

Thanks @Lewiky !

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lewiky, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuzisun
Copy link
Member

yuzisun commented Aug 22, 2021

/lgtm

@google-oss-robot google-oss-robot merged commit bf95b9d into kserve:master Aug 22, 2021
@Lewiky Lewiky deleted the python3.9 branch August 23, 2021 09:15
yuzisun added a commit that referenced this pull request Aug 24, 2021
* Update Alibi Explainers to 0.6.0 (#1720)

* Update Alibi Explainers to 0.6.0

* fix lint

* Update shap to 0.39.0

* Fix tests

* update explainer tabular test

* Enable tag based routing  (#1752)

* Fix rolled back version

* rollback the LatestRolledoutRevision to PreviousRolledoutRevision when canary traffic presents and LatestRolledoutRevision==LatestReadyRevision

* Add latestReady == latestCreated check

* Add tag based routing

* Enable tag routing

* Update tag based routing doc

* prevent nested directories in s3 to be created as file inside model directory /mnt/models (#1770)

* Upgrade ray[serve] to version 1.5.0, allowing kfserving to be installed on python3.9 (#1772)

* Update ray[serve] to v1.5.0, allowing python3.9 installs

* bump up version to 0.6.1

Co-authored-by: Dan Sun <dsun20@bloomberg.net>

Co-authored-by: cliveseldon <cc@seldon.io>
Co-authored-by: animesh-agarwal <42318085+animesh-agarwal@users.noreply.github.com>
Co-authored-by: Lewis Bell <lewisbell999@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kfserving==0.6.0 python package doesn't work with Python 3.9
4 participants