Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: adopting coschduling plugins with updated kubeflow/common #1526

Closed
wants to merge 1 commit into from

Conversation

zw0610
Copy link
Member

@zw0610 zw0610 commented Jan 26, 2022

What this PR does / why we need it:

Adopts updated kubeflow/common with PodGroupControl designed for more generic gang-schedulers.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1518

Checklist:

@aws-kf-ci-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zw0610

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Jan 26, 2022

Pull Request Test Coverage Report for Build 2804340476

  • 13 of 46 (28.26%) changed or added relevant lines in 6 files are covered.
  • 20 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 39.901%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/mxnet/mxjob_controller.go 0 3 0.0%
pkg/controller.v1/xgboost/xgboostjob_controller.go 0 3 0.0%
pkg/controller.v1/tensorflow/tfjob_controller.go 4 10 40.0%
pkg/controller.v1/register_controller.go 0 10 0.0%
pkg/controller.v1/mpi/mpijob_controller.go 6 17 35.29%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/register_controller.go 1 54.55%
pkg/common/util/scheduler.go 2 0%
pkg/controller.v1/mpi/mpijob_controller.go 8 77.49%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 61.71%
Totals Coverage Status
Change from base Build 2801069939: -0.05%
Covered Lines: 2327
Relevant Lines: 5832

💛 - Coveralls

@zw0610
Copy link
Member Author

zw0610 commented Jan 27, 2022

/ok-to-test

@zw0610 zw0610 force-pushed the coscheduling branch 2 times, most recently from 5cb2a51 to 37cd05d Compare May 1, 2022 07:25
@zw0610 zw0610 marked this pull request as ready for review May 1, 2022 07:57
@johnugeorge
Copy link
Member

/retest

@aws-kf-ci-bot
Copy link
Contributor

@zw0610: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-training-operator-presubmit 37cd05d link /test kubeflow-training-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zw0610
Copy link
Member Author

zw0610 commented May 2, 2022

@johnugeorge It seems the AWS eks dropping support for kuberntes ver. 1.18 cause many tests failed.

@johnugeorge
Copy link
Member

@zw0610 Do you plan to include this in the upcoming release?

@zw0610
Copy link
Member Author

zw0610 commented Jun 14, 2022

@zw0610 Do you plan to include this in the upcoming release?

no. Especially after #1610 , I believe there remain many changes to this pr.

update go mod for ci

fix changes
@tenzen-y
Copy link
Member

I take over this PR.

@johnugeorge
Copy link
Member

Can we close this PR as #1724 is merged

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member

/close

@google-oss-prow google-oss-prow bot closed this Sep 28, 2023
@google-oss-prow
Copy link

@tenzen-y: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PodGroup in scheduler-plugins/coscheduling
5 participants