Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

Change Statement unevict method to call UpdateTask #912

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

yodarshafrir1
Copy link
Contributor

@yodarshafrir1 yodarshafrir1 commented Nov 26, 2019

What this PR does / why we need it:
This change ensures that when unevict is called the value of nodeInfo.Releasing will be updated as if the task was evicted.

Before this fix, because the task exists on the current nodeInfo, every time unevict is called the Releasing value of the nodeInfo isn't updated and the value remains same as if the task was evicted

Why does it happen:
This happens because unevict calls AddTask:

// Update task in node.
if node, found := s.ssn.Nodes[reclaimee.NodeName]; found {
     node.AddTask(reclaimee)
} 

AddTask will throw an error because this task already exists under the current nodeInfo and therefore will not update the Releasing field as if the current task is Running

Issue: #907

…ask. This is needed in order to 'undo' the changes that were created during the call to 'evict' method (currently the node.Releasing value is wrong and will have the value as if the job was evicted, even if 'unevict' was called). When AddTask is called an error is returned because the task already exists in this node, and the Releasing value isn't set to the right value as if the job was never evicted.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 26, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @yodarshafrir1!

It looks like this is your first PR to kubernetes-sigs/kube-batch 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kube-batch has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @yodarshafrir1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 26, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 26, 2019
@yodarshafrir1
Copy link
Contributor Author

/assign @hex108

@yodarshafrir1 yodarshafrir1 changed the title Change statement.go unevict method to call UpdateTask instead of AddT… Change Statement unevict method to call UpdateTask Nov 26, 2019
@yodarshafrir1
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 26, 2019
@k82cn
Copy link
Contributor

k82cn commented Nov 27, 2019

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, yodarshafrir1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9052f4e into kubernetes-retired:master Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants