Skip to content

Commit

Permalink
feat: Add Conversion Webhooks for V1 APIs (#1356)
Browse files Browse the repository at this point in the history
  • Loading branch information
engedaam committed Jul 5, 2024
1 parent 5c0f1a7 commit e356a51
Show file tree
Hide file tree
Showing 11 changed files with 1,484 additions and 5 deletions.
2 changes: 1 addition & 1 deletion kwok/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ func main() {
op.GetClient(),
op.EventRecorder,
cloudProvider,
)...).Start(ctx)
)...).Start(ctx, cloudProvider)
}
123 changes: 123 additions & 0 deletions pkg/apis/v1/nodeclaim_conversion.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
/*
Copyright The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/

package v1

import (
"context"

"github.com/samber/lo"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/runtime/schema"
"knative.dev/pkg/apis"

"sigs.k8s.io/karpenter/pkg/apis/v1beta1"
"sigs.k8s.io/karpenter/pkg/operator/injection"
)

func (in *NodeClaim) ConvertTo(ctx context.Context, to apis.Convertible) error {
v1beta1NC := to.(*v1beta1.NodeClaim)
v1beta1NC.ObjectMeta = in.ObjectMeta

in.Spec.convertTo(ctx, &v1beta1NC.Spec)
in.Status.convertTo((&v1beta1NC.Status))
return nil
}

func (in *NodeClaimSpec) convertTo(ctx context.Context, v1beta1nc *v1beta1.NodeClaimSpec) {
v1beta1nc.Taints = in.Taints
v1beta1nc.StartupTaints = in.StartupTaints
v1beta1nc.Resources = v1beta1.ResourceRequirements(in.Resources)
v1beta1nc.Requirements = lo.Map(in.Requirements, func(v1Requirements NodeSelectorRequirementWithMinValues, _ int) v1beta1.NodeSelectorRequirementWithMinValues {
return v1beta1.NodeSelectorRequirementWithMinValues{
NodeSelectorRequirement: v1.NodeSelectorRequirement{
Key: v1Requirements.Key,
Operator: v1Requirements.Operator,
Values: v1Requirements.Values,
},
MinValues: v1Requirements.MinValues,
}
})

if in.NodeClassRef != nil {
nodeclass, found := lo.Find(injection.GetNodeClasses(ctx), func(nc schema.GroupVersionKind) bool {
return nc.Kind == in.NodeClassRef.Kind && nc.Group == in.NodeClassRef.Group
})
v1beta1nc.NodeClassRef = &v1beta1.NodeClassReference{
Kind: in.NodeClassRef.Kind,
Name: in.NodeClassRef.Name,
APIVersion: lo.Ternary(found, nodeclass.GroupVersion().String(), ""),
}
}

// Need to implement Kubelet Conversion
}

func (in *NodeClaimStatus) convertTo(v1beta1nc *v1beta1.NodeClaimStatus) {
v1beta1nc.NodeName = in.NodeName
v1beta1nc.ProviderID = in.ProviderID
v1beta1nc.ImageID = in.ImageID
v1beta1nc.Capacity = in.Capacity
v1beta1nc.Allocatable = in.Allocatable
v1beta1nc.Conditions = in.Conditions
}

func (in *NodeClaim) ConvertFrom(ctx context.Context, from apis.Convertible) error {
v1beta1NC := from.(*v1beta1.NodeClaim)
in.ObjectMeta = v1beta1NC.ObjectMeta

in.Status.convertFrom((&v1beta1NC.Status))
return in.Spec.convertFrom(ctx, &v1beta1NC.Spec)
}

func (in *NodeClaimSpec) convertFrom(ctx context.Context, v1beta1nc *v1beta1.NodeClaimSpec) error {
in.Taints = v1beta1nc.Taints
in.StartupTaints = v1beta1nc.StartupTaints
in.Resources = ResourceRequirements(v1beta1nc.Resources)
in.Requirements = lo.Map(v1beta1nc.Requirements, func(v1beta1Requirements v1beta1.NodeSelectorRequirementWithMinValues, _ int) NodeSelectorRequirementWithMinValues {
return NodeSelectorRequirementWithMinValues{
NodeSelectorRequirement: v1.NodeSelectorRequirement{
Key: v1beta1Requirements.Key,
Operator: v1beta1Requirements.Operator,
Values: v1beta1Requirements.Values,
},
MinValues: v1beta1Requirements.MinValues,
}
})

defaultNodeClassGVK := injection.GetNodeClasses(ctx)[0]
nodeclassGroupVersion, err := schema.ParseGroupVersion(v1beta1nc.NodeClassRef.APIVersion)
if err != nil {
return err
}
in.NodeClassRef = &NodeClassReference{
Name: v1beta1nc.NodeClassRef.Name,
Kind: lo.Ternary(v1beta1nc.NodeClassRef.Kind == "", defaultNodeClassGVK.Kind, v1beta1nc.NodeClassRef.Kind),
Group: lo.Ternary(v1beta1nc.NodeClassRef.APIVersion == "", defaultNodeClassGVK.Group, nodeclassGroupVersion.Group),
}

// Need to implement Kubelet Conversion
return nil
}

func (in *NodeClaimStatus) convertFrom(v1beta1nc *v1beta1.NodeClaimStatus) {
in.NodeName = v1beta1nc.NodeName
in.ProviderID = v1beta1nc.ProviderID
in.ImageID = v1beta1nc.ImageID
in.Capacity = v1beta1nc.Capacity
in.Allocatable = v1beta1nc.Allocatable
in.Conditions = v1beta1nc.Conditions
}
Loading

0 comments on commit e356a51

Please sign in to comment.