First review

kubernetes-sigs · Apr 12, 2022 · 913f808 · 913f808
1 parent 3b6f8db
commit 913f808
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 8 deletions.
diff --git a/PROJECT b/PROJECT
@@ -40,7 +40,6 @@ resources:
   version: v1alpha1
 - api:
     crdVersion: v1
-    namespaced: true
   domain: x-k8s.io
   group: config
   kind: KueueConfiguration

diff --git a/apis/config/v1alpha1/configuration_types.go b/apis/config/v1alpha1/configuration_types.go
@@ -27,7 +27,7 @@ import (
 type Configuration struct {
 	metav1.TypeMeta `json:",inline"`
 
-	// ControllerManagerConfigurationSpec returns the contfigurations for controllers
+	// ControllerManagerConfigurationSpec returns the configurations for controllers
 	cfg.ControllerManagerConfigurationSpec `json:",inline"`
 
 	// ManageJobsWithoutQueueName controls whether or not Kueue reconciles

diff --git a/config/default/manager_auth_proxy_patch.yaml b/config/default/manager_auth_proxy_patch.yaml
@@ -20,9 +20,3 @@ spec:
         - containerPort: 8443
           protocol: TCP
           name: https
-      - name: manager
-        args:
-        - "--health-probe-bind-address=:8081"
-        - "--metrics-bind-address=127.0.0.1:8080"
-        - "--leader-elect"
-        - "--zap-log-level=2"
diff --git a/config/default/manager_config_patch.yaml b/config/default/manager_config_patch.yaml
@@ -10,6 +10,7 @@ spec:
       - name: manager
         args:
         - "--config=controller_manager_config.yaml"
+        - "--zap-log-level=2"
         volumeMounts:
         - name: manager-config
           mountPath: /controller_manager_config.yaml