Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate workload PodSetUpdates #1187

Closed
mimowo opened this issue Oct 9, 2023 · 5 comments · Fixed by #1220
Closed

Validate workload PodSetUpdates #1187

mimowo opened this issue Oct 9, 2023 · 5 comments · Fixed by #1220
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mimowo
Copy link
Contributor

mimowo commented Oct 9, 2023

What happened:

It is possible to set workload PodSetUpdates with invalid values, resulting in errors during workload admission.

What you expected to happen:

Fail fast on modifications to workload.PodSetUpdates which are performed by external controllers.

Validated things:

Proposed solution: workload webhook.

Part of #1145

@mimowo mimowo added the kind/bug Categorizes issue or PR as related to a bug. label Oct 9, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Oct 9, 2023

FYI @mwielgus @trasc
/assign @stuton

@k8s-ci-robot
Copy link
Contributor

@mimowo: GitHub didn't allow me to assign the following users: stuton.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

FYI @mwielgus @trasc
/assign @stuton

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mimowo
Copy link
Contributor Author

mimowo commented Oct 11, 2023

FYI @alculquicondor

@alculquicondor
Copy link
Contributor

+1

@stuton
Copy link
Contributor

stuton commented Oct 13, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants