generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate workload PodSetUpdates #1187
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
@mimowo: GitHub didn't allow me to assign the following users: stuton. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. |
FYI @alculquicondor |
+1 |
/assign |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened:
It is possible to set workload PodSetUpdates with invalid values, resulting in errors during workload admission.
What you expected to happen:
Fail fast on modifications to
workload.PodSetUpdates
which are performed by external controllers.Validated things:
PodSetUpdates.name
should be a valid pod set namePodSetUpdates.tolerations
should a valid list of tolerations, see https://github.com/kubernetes/kubernetes/blob/57d3cc66050545d7fefb0841e750a0a41df14144/pkg/apis/core/validation/validation.go#L3749Proposed solution: workload webhook.
Part of #1145
The text was updated successfully, but these errors were encountered: