Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knobs to configure which jobs kueue manages #169

Closed
Tracked by #222
alculquicondor opened this issue Mar 31, 2022 · 6 comments
Closed
Tracked by #222

Knobs to configure which jobs kueue manages #169

alculquicondor opened this issue Mar 31, 2022 · 6 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/productionization priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@alculquicondor
Copy link
Contributor

What would you like to be added:

Currently, kueue takes over and suspends any Job in the system that is not admitted in a ClusterQueue.

Why is this needed:

There might be users in a cluster that are using the Job API for supporting services (like backups), instead of batch workloads. They would likely run in dedicated nodes that should not be subject to quotas.

Also, a custom workload might use a Job underneath, perhaps more than one. Once this custom workload is accepted as a whole, we don't want the Job to be queued as well.

Open questions:

  • Should we just do it per namespaces?
  • Can we use the namespace selectors from the ClusterQueues to decide? If the controller is re-starting, we might miss some.
  • Is an annotation in the job enough? This would cover both use cases, but it could be used by a malicious user to bypass Kueue.
@alculquicondor alculquicondor added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 31, 2022
@ahg-g
Copy link
Contributor

ahg-g commented Apr 1, 2022

I think we want a ConfigMap that includes a namespace selector to configure the job controller with which namespaces to work on. Should be none by default.

@ahg-g
Copy link
Contributor

ahg-g commented Apr 1, 2022

/assign

@ahg-g
Copy link
Contributor

ahg-g commented Apr 13, 2022

#207 adds component config with a flag to control if kueue will manage jobs without queue name set; defaults to not managing them.

We should still add a namespace selector to component config to allow limiting kueue to managing jobs in a select subset of namespaces.

@ahg-g ahg-g added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 13, 2022
@ahg-g ahg-g changed the title Ability to bypass queue for certain Jobs Knobs to configure the ability to bypass kueue for certain Jobs Apr 14, 2022
@ahg-g ahg-g changed the title Knobs to configure the ability to bypass kueue for certain Jobs Knobs to configure which jobs kueue will manage Apr 14, 2022
@ahg-g ahg-g changed the title Knobs to configure which jobs kueue will manage Knobs to configure which jobs kueue manages Apr 14, 2022
@ahg-g
Copy link
Contributor

ahg-g commented May 1, 2022

I feel that we do not yet need a namespace selector in component config, basing it on whether the queue-name is set is sufficient for now.

@ahg-g
Copy link
Contributor

ahg-g commented May 4, 2022

/close

@k8s-ci-robot
Copy link
Contributor

@ahg-g: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/productionization priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

3 participants