Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding featuregate for QueueVisibility #1139

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Adding featuregate for QueueVisibility #1139

merged 6 commits into from
Sep 20, 2023

Conversation

stuton
Copy link
Contributor

@stuton stuton commented Sep 19, 2023 •
edited by k8s-ci-robot
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Enable visibility of cluster queue using feature gate flag

Which issue(s) this PR fixes:

Fixes #1102

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 19, 2023
@netlify
Copy link

netlify bot commented Sep 19, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit dce28c4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/650b007156b81c0008847b5c

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @stuton. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 19, 2023
@tenzen-y
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 19, 2023
tenzen-y
tenzen-y reviewed Sep 19, 2023
View reviewed changes
pkg/features/kube_features.go Outdated Show resolved Hide resolved
pkg/features/kube_features.go Outdated Show resolved Hide resolved
test/integration/controller/core/suite_test.go Outdated Show resolved Hide resolved
@alculquicondor
Copy link
Contributor

/assign @mimowo

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2023
mimowo
mimowo reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a remark for additional unit test
/asssign @tenzen-y
/cc @alculquicondor

mimowo
mimowo reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ltgm

@mimowo
Copy link
Contributor

mimowo commented Sep 20, 2023

/ltgm

/lgtm
:)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: daacc4d02816293b8ffc7c17ce9b6d526a3a86a1

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
@tenzen-y
Copy link
Member

/release-note Enabling/disabling QueueVisibility using feature gate flag

@tenzen-y
Copy link
Member

/release-note-edit Enabling/disabling QueueVisibility using feature gate flag

@tenzen-y
Copy link
Member

/release-note-edit Enabling/disabling QueueVisibility using feature gate flag

@tenzen-y
Copy link
Member

The prow command doesn't seem to work well :(

@stuton Could you update the release note?

tenzen-y
tenzen-y reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9e27e42689905101a4d04fe204fdf470d811eade

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stuton, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 542d315 into kubernetes-sigs:main Sep 20, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Sep 20, 2023
@tenzen-y
Copy link
Member

/retitle Adding featuregate for cluster QueueVisibility

@k8s-ci-robot k8s-ci-robot changed the title Adding featuregate for cluster queue visibility Adding featuregate for cluster QueueVisibility Sep 20, 2023
@tenzen-y
Copy link
Member

/retitle Adding featuregate for QueueVisibility

@k8s-ci-robot k8s-ci-robot changed the title Adding featuregate for cluster QueueVisibility Adding featuregate for QueueVisibility Sep 20, 2023
@stuton
Copy link
Contributor Author

stuton commented Sep 20, 2023

The prow command doesn't seem to work well :(

@stuton Could you update the release note?

I updated the release note

@stuton stuton mentioned this pull request Oct 25, 2023
Closed
9 tasks
@alculquicondor
Copy link
Contributor

/release-note-edit

NONE

Since this is a follow up to #1069

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 25, 2023
@trasc trasc deleted the visibility-cq-featuregate branch March 12, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@trasc trasc Awaiting requested review from trasc

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@mimowo mimowo

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.

Add QueueVisibility to featureGate
5 participants
@stuton @k8s-ci-robot @tenzen-y @alculquicondor @mimowo