Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[multikueue] Don't use reconnecting clients in WL reconnecting. #1827

Merged
merged 2 commits into from
Mar 13, 2024
Merged

[multikueue] Don't use reconnecting clients in WL reconnecting. #1827

merged 2 commits into from
Mar 13, 2024

Conversation

trasc
Copy link
Contributor

@trasc trasc commented Mar 13, 2024 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Relates to #1814
Relates to #693

Special notes for your reviewer:

[multikueue] Don't use reconnecting clients in WL reconnecting.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 13, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 13, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit e134df1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/65f16a205ff2a30008ad5af4

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 13, 2024
@trasc trasc force-pushed the multikueue-skip-reconnecting-clients branch from 04d32af to 43d25fd Compare March 13, 2024 08:27
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 13, 2024
@trasc trasc changed the title MultiKueue skip reconnecting clients [multikueue] Don't use reconnecting clients in WL reconnecting. Mar 13, 2024
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 13, 2024
@trasc trasc marked this pull request as ready for review March 13, 2024 08:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2024
mimowo
mimowo reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one ask would be about unit test, if feasible.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2024
@mimowo
Copy link
Contributor

mimowo commented Mar 13, 2024

/test pull-kueue-test-integration-main
Does not seem related, I will open a dedicated issue

@mimowo
Copy link
Contributor

mimowo commented Mar 13, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6cdc2bd91c72731d2d8c74bc7a61a07c9832ab7c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8911641 into kubernetes-sigs:main Mar 13, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.7 milestone Mar 13, 2024
@trasc trasc deleted the multikueue-skip-reconnecting-clients branch March 13, 2024 12:42
vsoch pushed a commit to researchapps/kueue that referenced this pull request Apr 18, 2024
@trasc @vsoch
[multikueue] Don't use reconnecting clients in WL reconnecting. (kube…
cc2ae73 
…rnetes-sigs#1827)

* [multikueue] Don't use reconnecting clients in WL reconnecting.

* Add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@denkensk denkensk Awaiting requested review from denkensk

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@trasc @k8s-ci-robot @mimowo