Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed Queue to LocalQueue #341

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Renamed Queue to LocalQueue #341

merged 1 commit into from
Aug 19, 2022

Conversation

ahg-g
Copy link
Contributor

@ahg-g ahg-g commented Aug 18, 2022

What type of PR is this?

/kind cleanup
/kind api-change

What this PR does / why we need it:

Renames the namespaced resource Queue to LocalQueue.

Which issue(s) this PR fixes:

Part of #330

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 18, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 18, 2022
@ahg-g ahg-g force-pushed the local-queue branch 2 times, most recently from 59bf53b to 07b997e Compare August 18, 2022 21:29
alculquicondor
alculquicondor reviewed Aug 18, 2022
View reviewed changes
apis/kueue/v1alpha1/localqueue_types.go Show resolved Hide resolved
apis/kueue/webhooks/localqueue_webhook.go Show resolved Hide resolved
config/manager/kustomization.yaml Outdated Show resolved Hide resolved
pkg/cache/cache.go Outdated Show resolved Hide resolved
pkg/controller/core/localqueue_controller.go Outdated Show resolved Hide resolved
pkg/queue/manager.go Outdated Show resolved Hide resolved
pkg/queue/manager.go Outdated Show resolved Hide resolved
pkg/queue/manager.go Outdated Show resolved Hide resolved
kerthcet
kerthcet reviewed Aug 19, 2022
View reviewed changes
Copy link
Contributor

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The localQueue name referenced by other components is still queueName or kueue.x-k8s.io/queue-name, right?

@alculquicondor alculquicondor mentioned this pull request Aug 19, 2022
Closed
16 tasks
alculquicondor
alculquicondor reviewed Aug 19, 2022
View reviewed changes
Copy link
Contributor

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahg-g,alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ahg-g
ahg-g commented Aug 19, 2022
View reviewed changes
Copy link
Contributor Author

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more renames

config/manager/kustomization.yaml Outdated Show resolved Hide resolved
@ahg-g
Copy link
Contributor Author

ahg-g commented Aug 19, 2022

The localQueue name referenced by other components is still queueName or kueue.x-k8s.io/queue-name, right?

Yes, that will stay as is.

@ahg-g
Copy link
Contributor Author

ahg-g commented Aug 19, 2022

squashed

@alculquicondor
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit efa8b78 into kubernetes-sigs:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@kerthcet kerthcet kerthcet left review comments

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahg-g @k8s-ci-robot @alculquicondor @kerthcet