Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for stdin_open and tty keys #344

Closed
concaf opened this issue Dec 25, 2016 · 0 comments
Closed

support for stdin_open and tty keys #344

concaf opened this issue Dec 25, 2016 · 0 comments

Comments

@concaf
Copy link
Contributor

concaf commented Dec 25, 2016

Hi,

My docker-compose.yml looks something like -

version: "2"
services:
  client:
     image: registry.centos.org/centos/centos:7
     stdin_open: true
     tty: true

kompose up gives me -

WARN[0000] Unsupported stdin_open key - ignoring        
WARN[0000] Unsupported tty key - ignoring               
WARN[0000] [client] Service cannot be created because of missing port. 
We are going to create Kubernetes Deployments, Services and PersistentVolumeClaims for your Dockerized application. 
If you need different kind of resources, use the 'kompose convert' and 'kubectl create -f' commands instead. 

INFO[0000] Successfully created Deployment: client      

Your application has been deployed to Kubernetes. You can run 'kubectl get deployment,svc,pods,pvc' for details.

Since these keys are unsupported, the pod goes from Running to Completed to CrashLoopBackOff

$ kubectl get pods -w
NAME                      READY     STATUS              RESTARTS   AGE
client-2474090665-o7wdc   0/1       ContainerCreating   0          1s
NAME                      READY     STATUS      RESTARTS   AGE
client-2474090665-o7wdc   0/1       Completed   0          1s
client-2474090665-o7wdc   0/1       Completed   1         2s
client-2474090665-o7wdc   0/1       CrashLoopBackOff   1         3s
client-2474090665-o7wdc   0/1       Completed   2         16s

It would be great if stdin_open and tty could be supported.

Here is the equivalent in Kubernetes world -

apiVersion: extensions/v1beta1
kind: Deployment
...
spec:
...
  template:
    metadata:
    ...
    spec:
      containers:
      - stdin: true
        tty: true
        image: registry.centos.org/centos/centos:7
concaf added a commit to concaf/kompose that referenced this issue Dec 27, 2016
This adds supports for stdin_open: bool and
tty: bool support for kubernetes and openshift
providers in kompose. This maps to the
template.Spec.Containers[0].Stdin and
template.Spec.Containers[0].TTY in Kubernets
world.

Also, added tests.

Fixes kubernetes#344
concaf added a commit to concaf/kompose that referenced this issue Dec 27, 2016
This adds supports for stdin_open: bool and
tty: bool support for kubernetes and openshift
providers in kompose. This maps to the
template.Spec.Containers[0].Stdin and
template.Spec.Containers[0].TTY in Kubernets
world.

Also, added tests.

Fixes kubernetes#344
concaf added a commit to concaf/kompose that referenced this issue Dec 28, 2016
This adds supports for stdin_open: bool and
tty: bool support for kubernetes and openshift
providers in kompose. This maps to the
template.Spec.Containers[0].Stdin and
template.Spec.Containers[0].TTY in Kubernets
world.

Also, added tests.

Fixes kubernetes#344
surajssd added a commit that referenced this issue Dec 28, 2016
add stdin_open, tty support, add tests, fix #344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant