Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test showing PASS, even if command not found #431

Closed
surajnarwade opened this issue Feb 20, 2017 · 1 comment · Fixed by #526
Closed

test showing PASS, even if command not found #431

surajnarwade opened this issue Feb 20, 2017 · 1 comment · Fixed by #526

Comments

@surajnarwade
Copy link
Contributor

I tried to run,

$ make test-cmd

but I found this output,

===> Starting test <===
convert::expect_success: Running: 'kompose -f /home/snarwade/go/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/restart-options/docker-compose-restart-no.yml --provider openshift convert --stdout -j' expected_output: '/home/snarwade/go/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/restart-options/output-os-restart-no.json'
PASS: converted output matches
./script/test/cmd/tests.sh: line 117: convert::failure: command not found

===> Starting test <===
convert::check_artifacts_generated: Running: 'kompose -f /home/snarwade/go/src/github.com/kubernetes-incubator/kompose/examples/docker-compose.yml convert -o /tmp/kompose/output_file -j'
PASS: /tmp/kompose/output_file exists
./script/test/cmd/tests.sh: line 181: convert::expect_success_warning: command not found

Test are passing even if it shows command not found.

@surajssd
Copy link
Member

found one more similar

===> Starting test <===
convert::expect_success_and_warning: Running: 'kompose -f /home/hummer/go/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/ngnix-node-redis/docker-compose.yml convert --stdout -j' expected_output: '/home/hummer/go/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/ngnix-node-redis/output-k8s.json' expected_warning: 'Kubernetes provider doesn't support build key - ignoring'
PASS: converted output matches
PASS: warning found: 'Kubernetes provider doesn't support build key - ignoring'./script/test/cmd/tests.sh: line 48: convert::expect_success_warning: command not found

surajnarwade added a commit to surajnarwade/kompose that referenced this issue Mar 30, 2017
Fixes kubernetes#431

fixed commands where output showing `command not found` and k8s output
added for restart-options example.
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Mar 30, 2017
Fixes kubernetes#431

fixed commands where output showing `command not found` and k8s output
added for restart-options example.
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Mar 30, 2017
Fixes kubernetes#431

fixed commands where output showing `command not found` and k8s output
added for restart-options example.
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Mar 30, 2017
Fixes kubernetes#431

fixed commands where output showing `command not found` and k8s output
added for restart-options example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants