kompose passes a kubernetes deployment without image

[surajssd]

I have a docker-compose service with build specified but without image. So since kompose has no build support with kubernetes so it should error out saying that there is no image provided.

$ kompose up
WARN Kubernetes provider doesn't support build key - ignoring 
INFO We are going to create Kubernetes Deployments, Services and PersistentVolumeClaims for your Dockerized application. If you need different kind of resources, use the 'kompose convert' and 'kubectl create -f' commands instead. 
 
INFO Deploying application in "default" namespace 
INFO Successfully created Service: foo            
FATA Error while deploying application: Deployment.apps "foo" is invalid: spec.template.spec.containers[0].image: Required value 

I am using following docker-compose file:

$ cat docker-compose.yml 
version: '2'

services:
  foo:
    build: .

So I would recommend that we suggest user to add one more additional field called image to provide the image name explicitly.

[procrypt]

@surajssd Working on this.

[cdrage]

I don't believe this is an issue.

If an image key isn't passed, it will use the service name as per how it works in Docker Compose. I work around this in #521 (and thus merging #521 will fix this issue).

For your example, it will build as image "foo".

[surajssd]

@cdrage I would not want to do magic here and ask user to specifically provide the image name, because then user might be confused why this is failing!

[cdrage]

@surajssd I don't believe it's magic. This is how Docker Compose does it while building, so I don't see a problem with it converting to Kubernetes and taking the appropriate Docker Image name as the service name.

#521 will be adding the build functionality, so it may be best to wait until that's merged and then we can update this issue #571 in regards to warning the user that in-fact, there was no image specified and it will be using the service name for building / deployment.

[cdrage]

@surajssd @procrypt Should we close this? Did my comments address the problem?

[surajssd]

This should fail now right ?

[cdrage]

@surajssd No? I thought my comments address why having no image is still valid with build (it builds the docker container and tags it)

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale