-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Up and convert commands are not equal in features #798
Comments
cdrage
changed the title
kompose up and kompose convert is not consistent
kompose up and kompose commands are not equal in features
Aug 25, 2017
cdrage
changed the title
kompose up and kompose commands are not equal in features
Up and convert commands are not equal in features
Aug 25, 2017
Picking |
sending PR for |
This was referenced Sep 26, 2017
if we are adding |
surajnarwade
added a commit
to surajnarwade/kompose
that referenced
this issue
Nov 14, 2017
To make `kompose up` & `kompose convert` equal in feature, This PR will add `--controller` flag for `kompose up` as well as `kompose down` so that user experience will be the same for `up` & `convert` Resolves kubernetes#798
surajnarwade
added a commit
to surajnarwade/kompose
that referenced
this issue
Nov 21, 2017
To make `kompose up` & `kompose convert` equal in feature, This PR will add `--controller` flag for `kompose up` as well as `kompose down` so that user experience will be the same for `up` & `convert` Resolves kubernetes#798 since we are adding `--controller` to `up` and `down`, So respective code to deploy and undeploy also being added for `daemonset` and `replicationcontroller`
surajnarwade
added a commit
to surajnarwade/kompose
that referenced
this issue
Nov 27, 2017
To make `kompose up` & `kompose convert` equal in feature, This PR will add `--controller` flag for `kompose up` as well as `kompose down` so that user experience will be the same for `up` & `convert` Resolves kubernetes#798 since we are adding `--controller` to `up` and `down`, So respective code to deploy and undeploy also being added for `daemonset` and `replicationcontroller` Added tests for `--controller`
procrypt
pushed a commit
to procrypt/kompose
that referenced
this issue
Feb 4, 2018
To make `kompose up` & `kompose convert` equal in feature, This PR will add `--controller` flag for `kompose up` as well as `kompose down` so that user experience will be the same for `up` & `convert` Resolves kubernetes#798 since we are adding `--controller` to `up` and `down`, So respective code to deploy and undeploy also being added for `daemonset` and `replicationcontroller` Added tests for `--controller`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example, we are able to deploy --daemon-set using
convert
, but not withup
.We have some things such as
--build
which is consistent inkompose up
, but other aspects such as controllers, etc do not function correctly.We should have the SAME experience between
up
andconvert
.It goes against UX/UI having inconsistencies between the commands. One should convert, one should bring those converted up.
List of parameters NOT in
up
:A couple of these parameters will be deprecated in favour of
--controller
however.The text was updated successfully, but these errors were encountered: