Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong warning about networks #88

Closed
surajssd opened this issue Aug 6, 2016 · 1 comment
Closed

Wrong warning about networks #88

surajssd opened this issue Aug 6, 2016 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@surajssd
Copy link
Member

surajssd commented Aug 6, 2016

wrong warning about networks not supported, even if networks not provided: WARN[0000] Unsupported key networks - ignoring

using docker-compose.yml

$ cat docker-compose.yml 
version: "2"

services:
  redis:
    image: dharmit/redis
    command: redis-server
    ports:
      - "6379"
    volumes:
      - /opt/redis:/redis

  flask:
    image: dharmit/flask
    ports:
      - "31000:5000"
    depends_on:
      - redis
    environment:
      REDIS_PORT: 6379
      REDIS_HOST: redis

Output

$ kompose convert --stdout -f docker-compose.yml -y
WARN[0000] Unsupported key depends_on - ignoring        
WARN[0000] Unsupported key networks - ignoring          
apiVersion: v1
kind: Service
metadata:
  creationTimestamp: null
  labels:
    service: redis
  name: redis
spec:
  ports:
  - name: "6379"
    port: 6379
@ngtuna
Copy link
Contributor

ngtuna commented Aug 6, 2016

Good catch @surajssd . And I believe only networks field causes this issue as it is pointer (only) in ServiceConfig struct.

@ngtuna ngtuna added the kind/bug Categorizes issue or PR as related to a bug. label Aug 8, 2016
@ngtuna ngtuna closed this as completed in 8ddadfc Aug 10, 2016
ngtuna added a commit that referenced this issue Aug 10, 2016
enhance warning: networks, network config, volume config. Fixes #88, #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants