Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support node.labels at placement #1041

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Support node.labels at placement #1041

merged 2 commits into from
Jul 5, 2018

Conversation

jvitor83
Copy link
Contributor

@jvitor83 jvitor83 commented Jun 21, 2018 •
edited
Loading

This PR just give the ability to put any custom label (not mapped) at placement.constraints

    deploy:
      placement:
        constraints:
        - node.labels.something == anything

Just for link the original PR for placement: #813

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2018
@hangyan
Copy link
Contributor

hangyan commented Jul 4, 2018

@jvitor83 Hi, Sorry about the very later response. Would mind to add some tests or modify the existing ones? there are many examples there

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2018
@jvitor83
Copy link
Contributor Author

jvitor83 commented Jul 4, 2018

@hangyan Hi. I did a test about my modification.

@hangyan hangyan merged commit 379b654 into kubernetes:master Jul 5, 2018
@hangyan
Copy link
Contributor

hangyan commented Jul 5, 2018

@jvitor83 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangyan hangyan hangyan approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvitor83 @hangyan @k8s-ci-robot