Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add node references" #1145

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Revert "Add node references" #1145

merged 1 commit into from
Jun 21, 2019

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Jun 20, 2019

Reverts #1123

Reverts back to using "slave". Unfortunately, we rely on Google's examples. Once google-samples is updated to using node we'll switch back!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign cdrage
You can assign the PR to them by writing /assign @cdrage in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 20, 2019
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2019
@hangyan
Copy link
Contributor

hangyan commented Jun 21, 2019

/lgtm

@hangyan hangyan merged commit ef241ad into master Jun 21, 2019
@hangyan hangyan mentioned this pull request Jun 21, 2019
@cdrage cdrage deleted the revert-1123-node-references branch October 29, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants