Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Key Translation Feature and test cases #1195

Merged
merged 1 commit into from
Dec 1, 2019
Merged

Network Key Translation Feature and test cases #1195

merged 1 commit into from
Dec 1, 2019

Conversation

mudverma
Copy link
Contributor

Fixes #1188

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign janetkuo
You can assign the PR to them by writing /assign @janetkuo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mudverma mudverma mentioned this pull request Nov 30, 2019
Closed
hangyan
hangyan approved these changes Dec 1, 2019
View reviewed changes
Copy link
Contributor

@hangyan hangyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for your contribution @mudverma

@hangyan hangyan merged commit ac2b852 into kubernetes:master Dec 1, 2019
@mudverma mudverma mentioned this pull request Dec 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangyan hangyan hangyan approved these changes

@ngtuna ngtuna Awaiting requested review from ngtuna

@surajssd surajssd Awaiting requested review from surajssd

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Achieve Docker-Compose Network functionality using NetworkPolicy in Kubernates
3 participants
@mudverma @k8s-ci-robot @hangyan