Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify default kubernetes client's apiserver url #1204

Merged
merged 3 commits into from
Dec 24, 2019
Merged

Modify default kubernetes client's apiserver url #1204

merged 3 commits into from
Dec 24, 2019

Conversation

hangyan
Copy link
Contributor

@hangyan hangyan commented Dec 24, 2019

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hangyan
You can assign the PR to them by writing /assign @hangyan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hangyan
Copy link
Contributor Author

hangyan commented Dec 24, 2019

fix #1131

#1201 is on openshift, i don't have a openshift env for now, may be check it out later.

@hangyan hangyan requested a review from cdrage December 24, 2019 09:50
@hangyan
Copy link
Contributor Author

hangyan commented Dec 24, 2019

@cdrage Now i realize i can force merge a PR ..... I will merge this first, since it's critical for normal usage. You can review it anytime.

@hangyan hangyan merged commit d52fd0d into kubernetes:master Dec 24, 2019
@hangyan hangyan deleted the up branch December 24, 2019 10:47
@fmotrifork fmotrifork mentioned this pull request Mar 3, 2020
Merged
@ghost ghost mentioned this pull request Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel Awaiting requested review from kadel

@ngtuna ngtuna Awaiting requested review from ngtuna

@cdrage cdrage Awaiting requested review from cdrage

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hangyan @k8s-ci-robot