Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chart lint #1205

Merged
merged 1 commit into from
Dec 25, 2019
Merged

Fix chart lint #1205

merged 1 commit into from
Dec 25, 2019

Conversation

hangyan
Copy link
Contributor

@hangyan hangyan commented Dec 25, 2019

Fix #1200

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hangyan
You can assign the PR to them by writing /assign @hangyan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hangyan
Copy link
Contributor Author

hangyan commented Dec 25, 2019

Only tested on helm v3

@hangyan hangyan merged commit 4cbe106 into kubernetes:master Dec 25, 2019
@hangyan hangyan deleted the chart-lint branch December 25, 2019 10:13
@fmotrifork fmotrifork mentioned this pull request Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrage cdrage Awaiting requested review from cdrage

@ngtuna ngtuna Awaiting requested review from ngtuna

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm lint throws errors on chart.yaml
2 participants
@hangyan @k8s-ci-robot