Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configmap name case error #1215

Merged
merged 3 commits into from
Dec 27, 2019
Merged

Conversation

hangyan
Copy link
Contributor

@hangyan hangyan commented Dec 27, 2019

For somehow, all the Name field of configmaps(object ref) does not serialize correctly, strangely only k8s templates was affects. Seems like the cause is

vendor/k8s.io/kubernetes/pkg/api/types.go
// LocalObjectReference contains enough information to let you locate the referenced object inside the same namespace.
type LocalObjectReference struct {
	//TODO: Add other useful fields.  apiVersion, kind, uid?
	Name string
}

For now i will update the vendor code and use vendor-update to keep it sync.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign hangyan
You can assign the PR to them by writing /assign @hangyan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hangyan hangyan merged commit bc32e29 into kubernetes:master Dec 27, 2019
@hangyan hangyan deleted the fix-cm-name branch December 27, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants