Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make --file as global flag #139

Merged
merged 4 commits into from
Sep 6, 2016
Merged

make --file as global flag #139

merged 4 commits into from
Sep 6, 2016

Conversation

ngtuna
Copy link
Contributor

@ngtuna ngtuna commented Sep 2, 2016

Fix #138

/cc @Runseb

@janetkuo
Copy link
Member

janetkuo commented Sep 2, 2016

Looks like -f now needs to come right after kompose and before subcommands? We need to update all related docs as well (since we used kompose convert -f in our docs)

@ngtuna
Copy link
Contributor Author

ngtuna commented Sep 3, 2016

@janetkuo Right. Will add a follow up commit.

@sebgoa
Copy link
Contributor

sebgoa commented Sep 5, 2016

LGTM let's wait for @janetkuo to reply

@kadel
Copy link
Member

kadel commented Sep 6, 2016

@ngtuna can you please rebase this to current master?
There are two new tests as part of #127, they have to be updated also.

@ngtuna
Copy link
Contributor Author

ngtuna commented Sep 6, 2016

@kadel Done

@kadel
Copy link
Member

kadel commented Sep 6, 2016

thank you. lgtm

@ngtuna
Copy link
Contributor Author

ngtuna commented Sep 6, 2016

So I'm gonna merge it now.

@ngtuna ngtuna merged commit 3cfa129 into kubernetes:master Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ngtuna @janetkuo @sebgoa @kadel