Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tag experimental #229

Merged
merged 1 commit into from
Oct 26, 2016
Merged

remove tag experimental #229

merged 1 commit into from
Oct 26, 2016

Conversation

ngtuna
Copy link
Contributor

@ngtuna ngtuna commented Oct 20, 2016

Fix #228

Follow up discussion at #216 , it's good to remove tag experimental of bundlefile at this moment. By copying its structs and loadFile() function, we can also shorten the vendor list.

@ngtuna
Copy link
Contributor Author

ngtuna commented Oct 20, 2016

Sort out the vendor list will be added in a separate PR. I just tried doing that but there was a problem with godep restore again. Spend time figure it out tomorrow.

@dustymabe
Copy link
Contributor

Follow up discussion at #226,

I think you have the wrong number

@ngtuna
Copy link
Contributor Author

ngtuna commented Oct 21, 2016

Correct. It should be #216

Copy link
Member

@kadel kadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kadel kadel added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2016
@ngtuna ngtuna merged commit da44a5d into kubernetes:master Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants