Add support for user directive #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested changes
Oct 27, 2016
| if service.User != "" { | ||
| uid, err := strconv.ParseInt(service.User, 10, 64) | ||
| if err != nil { | ||
| logrus.Warn("Ignoring User directive. User has to specfied as uid (numeric).") |
There was a problem hiding this comment.
Just a little spelling error :)
Ignoring user directive. User to be specified as a UID (numeric).
cdrage
reviewed
Oct 27, 2016
| securityContext.Privileged = &service.Privileged | ||
| } | ||
| if service.User != "" { | ||
| uid, err := strconv.ParseInt(service.User, 10, 64) |
There was a problem hiding this comment.
What are these numbers? 10 and 64?
There was a problem hiding this comment.
10 is base of the number. (maybe i can change it to 0 that should do autodetection)
and 64 means that number has to fit into int64 (it will throw error if it is bigger than in64 :-) ) - runAsUser in Kubernetes SecurityContext is int64
|
Failing tests? |
yeah :-( It adds empty security context for every container ( |
kadel
force-pushed
the
user
branch
4 times, most recently
from
3abe292
to
e917947
Compare
|
fixed and rebased |
ngtuna
approved these changes
Nov 2, 2016
ngtuna
added
the
lgtm
|
unit tests? |
k8s-ci-robot
added
the
cncf-cla: yes
|
rebased and added test |
|
@kadel It needs rebase again |
|
rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is little a bit user unfriendly :-(
Issue is that in docker-compose you can set
userby user name or uid. But K8S allows you to set user only by its uid (has to be int).This is why I added warning that tells user that
userdirective will be ignored if its not a number.Here is user unfriendly part, in docker-compose even if you set user by it uid, it has to be string. (user: "2324") If you set it as int (user: 2324) libcompose parser will complain about this not being string.
So now Kompose requires
userto be number but written as string :-(fixes #244