Add go vet, and gofmt tests.
#259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadel
force-pushed
the
lint-and-vet
branch
6 times, most recently
from
dde77b3
to
205d0d7
Compare
|
Might be reasonable to turn on golint in a separate PR since govet and gofmt would be good to have on their own. |
k8s-ci-robot
added
the
cncf-cla: yes
kadel
changed the title
go vet, golint and gofmt tests.go vet, and gofmt tests.
Travis now runs `make validate` as first test. Make validate includes all validate tests (go vet, gofmt)
|
I've removed golint from this PR. as suggested by @ericchiang I'll turn it back on in separate PR with fixing all golint errors. (#307) This is ready for review and merge. |
cdrage
approved these changes
Nov 24, 2016
| @@ -133,12 +133,12 @@ func (b *Bundle) LoadFile(file string) kobject.KomposeObject { | |||
|
|
|||
| buf, err := ioutil.ReadFile(file) | |||
| if err != nil { | |||
| logrus.Fatalf("Failed to read bundles file: ", err) | |||
| logrus.Fatalf("Failed to read bundles file: %s ", err) | |||
|
LGTM my end! |
ngtuna
approved these changes
Nov 25, 2016
surajssd
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #215
Add
go vet,golintandgofmttests.Travis now runs
make validateas first target.make validateincludes all validate tests (go vet, golint, gofmt)TODO:
fix golint errorsadd golint check to travis-ci #307