Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report code coverage to coveralls #329

Merged
merged 1 commit into from
Dec 7, 2016
Merged

Report code coverage to coveralls #329

merged 1 commit into from
Dec 7, 2016

Conversation

kadel
Copy link
Member

@kadel kadel commented Dec 7, 2016

quick fix for Coveralls problem
#287

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 7, 2016
@sebgoa
Copy link
Contributor

sebgoa commented Dec 7, 2016

LGTM

@kadel
Copy link
Member Author

kadel commented Dec 7, 2016

lets wait untill travis job finishes.

I only tested this on my fork.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 373ab36 on kadel:coveralls-fix into ** on kubernetes-incubator:master**.

@kadel
Copy link
Member Author

kadel commented Dec 7, 2016

Wheeee, it works ;-)

Only down side is that number it reports is coverage of lines from files that have tests.
So packages without any tests are not included in this.

@kadel
Copy link
Member Author

kadel commented Dec 7, 2016

This was quickest solution that I could think of.
It would be great to get something little bit cleaner.

@kadel kadel merged commit 862419b into kubernetes:master Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebgoa sebgoa sebgoa approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kadel @sebgoa @coveralls @k8s-ci-robot