Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for raw pod output without controller #334

Merged
merged 1 commit into from
Dec 15, 2016
Merged

support for raw pod output without controller #334

merged 1 commit into from
Dec 15, 2016

Conversation

surajssd
Copy link
Member

if a user specifies a docker-compose service with restart value as "no" or "on-failure" then normal pod will be created as against to a controller and a pod.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2016
@surajssd surajssd changed the title support for raw pod output support for raw pod output without controller Dec 12, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 34.256% when pulling 66ce7c1 on surajssd:create_pod into 04a3131 on kubernetes-incubator:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 34.256% when pulling 921d936 on surajssd:create_pod into 04a3131 on kubernetes-incubator:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.9%) to 36.812% when pulling 905be26 on surajssd:create_pod into 65e19e3 on kubernetes-incubator:master.

@surajssd
Copy link
Member Author

ping @ngtuna @sebgoa

@coveralls
Copy link

Coverage Status

Coverage increased (+1.9%) to 36.812% when pulling ca0bd90 on surajssd:create_pod into 65e19e3 on kubernetes-incubator:master.

@surajssd
support for raw pod output
6ea5f72 
if a user specifies a docker-compose service
with restart value as "no" or "on-failure"
then normal pod will be created as against
to a controller and a pod.
@ngtuna
Copy link
Contributor

ngtuna commented Dec 13, 2016

@surajssd LGTM. Just notice github provided Reviewers button for requesting a review from specific person(s).

@coveralls
Copy link

Coverage Status

Coverage increased (+1.9%) to 36.812% when pulling 6ea5f72 on surajssd:create_pod into 65e19e3 on kubernetes-incubator:master.

@ngtuna ngtuna mentioned this pull request Dec 13, 2016
Closed
@surajssd
Copy link
Member Author

@ngtuna thanks for review, yes will use that reviewers button next time.

@surajssd
Copy link
Member Author

@ngtuna thanks fore review, merging 👍

@surajssd surajssd merged commit 78845d3 into kubernetes:master Dec 15, 2016
@sstarcher sstarcher mentioned this pull request Jan 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngtuna ngtuna ngtuna approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@surajssd @coveralls @ngtuna @k8s-ci-robot