Update vendoring as well as libcompose

[cdrage]

This commit updates libcompose in order to merge in
docker/libcompose#423 which affected
#92 by not
erroring out when an image name wasn't provided.

Closes #92

As well as knocks out the last required milestone for a 0.2.1 release
https://github.com/kubernetes-incubator/kompose/milestone/2

[cdrage]

ping @ngtuna as this closes your issue.

With this PR, we will have completed all milestones for 0.2.1 which unblocks us for releasing a new version of kompose. https://github.com/kubernetes-incubator/kompose/milestone/2

[coveralls]

Coverage remained the same at 46.617% when pulling 63f44be on cdrage:update-vendoring into b059c44 on kubernetes-incubator:master.

[ngtuna]

+1 @cdrage.

I was inserting a manual check for image while libcompose has not been updated, but your PR is here so we will work on this. Now I'm considering the test cases failing.

[coveralls]

Coverage remained the same at 46.617% when pulling 5703942 on cdrage:update-vendoring into 6e260ba on kubernetes-incubator:master.

[cdrage]

@ngtuna @kadel So this seems to be failing due to:

▶ kompose --provider openshift -f /home/wikus/dropbox/dev/go/src/github.com/kubernetes-incubator/kompose/script/test/fixtures/tty-true/docker-compose.yml convert --stdout -j                                                                                                     
etes-incubator/kompose/script/test/fixtures/tty-true/output-oc.json                                                                                                                                                                                                               
WARN[0000] Unsupported root level networks key - ignoring                                                                                                          
{                                                                                                                         
  "kind": "List",                         
  "apiVersion": "v1",                
  "metadata": {},                                                                                                                                                                                                                                                                 
  "items": [                                                                                                                                                                                                                                                                      
    {                               

appearing..

Going to investigate this more.. But looks like an update to libcompose added that warning.

[kadel]

@cdrage

There is a check that was testing root level networks before
https://github.com/kubernetes-incubator/kompose/blob/4f176b847ec75f61ab69bcc03f2b759a178df991/pkg/loader/compose/compose.go#L87

It looks like new libcompose version is doing something little bit different with networks :-(

[cdrage]

@kadel yeah :( i saw, seems that it's something putting something into the file even though a network isn't there. I'll open up a separate PR for this to unblock this PR.

[kadel]

I don't think that we should merge this if it is giving warning about root level network even there is none in docker-compose file. We should include fix in this pr.

[cdrage]

@kadel Done. I've added another commit to this PR that fixes the test.

[coveralls]

Coverage increased (+0.1%) to 46.744% when pulling 7cc7824 on cdrage:update-vendoring into 6e260ba on kubernetes-incubator:master.

[kadel]

LGTM.
But it might be good to have another pair of eyes to check it.

[cdrage]

@ngtuna @surajssd can we get a quick review? :)

[coveralls]

Coverage increased (+0.03%) to 47.042% when pulling 39fbc4a on cdrage:update-vendoring into 7dbf00c on kubernetes-incubator:master.

[ngtuna]

@cdrage LGTM

[surajssd]

@cdrage please uncomment this https://github.com/kubernetes-incubator/kompose/blob/master/script/test/cmd/tests.sh#L25

before we merge this!

[cdrage]

@surajssd

Done. Have a quick look and give me the LGTM 👍 Then we can merge!

[cdrage]

@containscafeine I'll have to open up a separate PR in regards to updating libcompose as for some odd reason you can't do glide update --strip-vendor in a detached HEAD state when you do a git rebase.

Mind doing a quick LGTM so I can press that merge button?

[concaf]

@cdrage sure, lookin' gooood to me!!!