Support insecure registry and enhance parsing of image stream tag #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
cdrage
requested changes
Apr 6, 2017
cmd/convert.go
Outdated
| @@ -101,9 +103,11 @@ func init() { | |||
|
|
|||
| // OpenShift only | |||
| convertCmd.Flags().BoolVar(&ConvertDeploymentConfig, "deployment-config", true, "Generate an OpenShift deploymentconfig object") | |||
| convertCmd.Flags().BoolVar(&ConvertInsecureRepo, "insecure-repository", false, "Specify to use insecure docker repository while generating Openshift image stream object") | |||
There was a problem hiding this comment.
Hi @qujinping this description may be better:
Use an insecure Docker repository for OpenShift ImageStream
cmd/up.go
Outdated
| @@ -56,5 +58,6 @@ var upCmd = &cobra.Command{ | |||
| func init() { | |||
| upCmd.Flags().BoolVar(&UpEmptyVols, "emptyvols", false, "Use empty volumes. Do not generate PersistentVolumeClaim") | |||
| upCmd.Flags().IntVar(&UpReplicas, "replicas", 1, "Specify the number of replicas generated") | |||
| upCmd.Flags().BoolVar(&UpInsecureRepo, "insecure-repository", false, "Specify to use insecure docker repository while generating Openshift image stream object") | |||
There was a problem hiding this comment.
Hi @qujinping this description may be better:
Use an insecure Docker repository for OpenShift ImageStream
|
@qujinping Saw the changes! One last thing and we can merge! Can you please squash your commits? |
yep, this is last think even for me. Once this get squashed its ready to be merged. |
|
Squashed as it should be :) Thanks. |
kadel
approved these changes
Apr 7, 2017
cdrage
approved these changes
Apr 7, 2017
|
LGTM! Thanks a lot for your contributions @qujinping!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 2 enhancements for openshift:
- support insecure docker registry for generation of openshift image stream
we add an import policy for the image stream tag by following instruction of the command argument
- enhance parsing of image tag
current implementation doesn't support format like "myregistryhost:5000/fedora/httpd:version1.0". Enhance the parsing logic.