Add io.kompose.service label to every object & use reaper to delete BuildConfig #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
kadel
force-pushed
the
add-label
branch
2 times, most recently
from
bd45726
to
a2ed264
Compare
kadel
changed the title
kadel
force-pushed
the
add-label
branch
6 times, most recently
from
aedf458
to
9c3aa1a
Compare
surajssd
reviewed
May 3, 2017
There was a problem hiding this comment.
I thought this was added to all the the controller types that came to function UpdateKubernetesObjects in k8sutils.go. Because the function has a line template.ObjectMeta.Labels = transformer.ConfigLabels(name)
If this was not set somewhere this is being replaced it seems.
|
@surajssd |
|
@kadel oh yes, thanks for clarifying that one. |
label added to BuildConfig, DaemonSet, ReplicationController, Deployment and Pod
added files required by BuildConfig reaper
|
I don't see anything wrong with the code, testing it, it works as intended! LGTM! |
cdrage
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.kompose.servicelabel to BuildConfig, DaemonSet, ReplicationController and Pod.Now every object created by Kompose should have this label.
Only some of the objects had this label before. This fixes #382