remove duplicate import with different name #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`k8s.io/kubernetes/pkg/api` is imported directly and once with the alias import name `kapi` so remove the original import and keep the aliased with `kapi` one and also replace the code bits which call it with `api` name.
k8s-ci-robot
added
the
cncf-cla: yes
|
LGTM. |
|
@cdrage you will have to approve it to merge it! |
cdrage
approved these changes
May 15, 2017
|
@surajssd Got to wait for one more approval. @surajnarwade @kadel @containscafeine @rtnpro ? |
|
@cdrage thanks 👍 |
|
@surajssd Try to wait until 2 people approve it 👍 before any merges :) |
|
@cdrage sure ! I thought this is smaller one, with mainly name changes so merged it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8s.io/kubernetes/pkg/apiis imported directly and once with the alias import namekapiso remove the original import and keep the aliased withkapione and also replace the code bits which call it withapiname.