-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable dab #653
Disable dab #653
Conversation
so +1 , except that as you mention MarkDeprecated does not work. |
@sebgoa Yes, an issue with Cobra, which already has a fix, see: spf13/cobra#466 will just have to wait until it's merged upstream. But since we error out anyways if |
I've also updated the commit title / information. We're disabling DAB not removing it, as the code for conversion is still there for future use! |
See issue: kubernetes#390 Disable DAB as it is hard to maintain / not much usage / DAB is still experimental in Docker and there hasn't been much movement: moby/moby#26876 MarkDeprecated does not work at the moment due to issue: kubernetes#652 However, that is not a blocker as we `fatalF` within `ValidateFlags`
works for me :) |
@cdrage LGTM and +1 for disabling DAB 💃 |
@cdrage Do we need to write the |
@procrypt @surajnarwade Remeber to go through the review process and hit "approve" 👍 But since I got two confirmations, let's go ahead and merge this! |
See issue: #390
Remove DAB as it is hard to maintain / not much usage / DAB is still
experimental in Docker and there hasn't been much movement:
moby/moby#26876
MarkDeprecated does not work at the moment due to issue:
#652
However, that is not a blocker as we
fatalF
withinValidateFlags