Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPU limit, CPU Reservation and Memory Reservation #738

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Aug 1, 2017

This adds support for CPU limit, CPU reservation as well as memory
reservation.

Specifically, when using the deploy key in Docker Compose.

@kompose-bot
Copy link
Collaborator

@cdrage, thank you for the pull request! We'll ping some people to review your PR. @surajnarwade and @kadel, please review this.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2017
@cdrage cdrage force-pushed the add-cpus branch 2 times, most recently from 9555937 to 4b90ec0 Compare August 1, 2017 20:16
@cdrage cdrage force-pushed the add-cpus branch 2 times, most recently from 814eae0 to f5ae6eb Compare August 2, 2017 14:09
This adds support for CPU limit, CPU reservation as well as memory
reservation.

Specifically, when using the `deploy` key in Docker Compose.
@surajnarwade
Copy link
Contributor

LGTM

Copy link
Member

@surajssd surajssd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdrage cdrage merged commit 86c047d into kubernetes:master Aug 8, 2017
@orkenstein
Copy link

orkenstein commented Jun 28, 2019

The doc says there's only support for limits. Are reservations supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants