Add Goreport badge #743
Add Goreport badge #743
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
@asifdxtreme , LGTM 👍 , it will be awesome if you send corrections for goreport resullts |
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Kompose (Kubernetes + Compose) | |||
|
|
|||
| [![Build Status Widget]][Build Status] [![Coverage Status Widget]][Coverage Status] [![GoDoc Widget]][GoDoc] [![Slack Widget]][Slack] | |||
| [![Build Status Widget]][Build Status] [![Coverage Status Widget]][Coverage Status] [![GoDoc Widget]][GoDoc] [![Slack Widget]][Slack] [](https://goreportcard.com/report/github.com/kubernetes/kompose) | |||
There was a problem hiding this comment.
Hi, please add the URL to the bottom of the page, you'll see where the other URL's are.
There was a problem hiding this comment.
Moved to the URL's to the bottom of the page.
|
@cdrage Thanks for the review, I have updated the changes as per the suggestion |
|
@surajnarwade Thanks for the suggestion, I will send the correction for goreport in later PR's. |
|
@cdrage the PR is updated as per your suggestions, can you please help me to merge this PR |
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # Kompose (Kubernetes + Compose) | |||
|
|
|||
| [![Build Status Widget]][Build Status] [![Coverage Status Widget]][Coverage Status] [![GoDoc Widget]][GoDoc] [![Slack Widget]][Slack] | |||
| [![Build Status Widget]][Build Status] [![Coverage Status Widget]][Coverage Status] [![GoDoc Widget]][GoDoc] [![Slack Widget]][Slack] [![GoReportCard Widget]][GoReportCardResult] | |||
There was a problem hiding this comment.
One last nitpick (sorry!), mind moving slack to being the last widget / move goreportcard forward? Other than that, LGTM after this has been changed!
There was a problem hiding this comment.
yes that makes sense, thanks for bringing this up, changed as per the suggestion
|
@cdrage Thanks for the suggestion, I have done the changes as requested |
|
I appreciated it! thanks man. |
No description provided.