Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant strings.ToLower() #808

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Remove redundant strings.ToLower() #808

merged 1 commit into from
Sep 11, 2017

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Sep 6, 2017

Removes the redundant strings.ToLower commands for GlobalProvider in
up.go, convert.go and down.go

@cdrage
Remove redundant strings.ToLower()
a930ce2 
Removes the redundant strings.ToLower commands for GlobalProvider in
up.go, convert.go and down.go
@kompose-bot
Copy link
Collaborator

@cdrage, thank you for the pull request! We'll request some people to review your PR. @surajssd and @kadel, please review this.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2017
@surajnarwade
Copy link
Contributor

works for me, LGTM 👍

@cdrage cdrage merged commit cf7d0d1 into kubernetes:master Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surajnarwade surajnarwade surajnarwade approved these changes

@kadel kadel Awaiting requested review from kadel

@surajssd surajssd Awaiting requested review from surajssd

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdrage @kompose-bot @surajnarwade @k8s-ci-robot