Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reference to emptyDir in OpenShift test scripts #815

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Fix reference to emptyDir in OpenShift test scripts #815

merged 1 commit into from
Sep 26, 2017

Conversation

ashetty1
Copy link
Contributor

No description provided.

@kompose-bot
Copy link
Collaborator

@ashetty1, thank you for the pull request! We'll request some people to review your PR. @cdrage, please review this.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2017
@cdrage
Copy link
Member

cdrage commented Sep 13, 2017

LGTM

@cdrage
Copy link
Member

cdrage commented Sep 13, 2017

@ashetty1 Please change the title to something informative (remove Fix PR 811) and add a description to the commit! Thank you.

cdrage
cdrage approved these changes Sep 18, 2017
View reviewed changes
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after title + description commit updates.

@ashetty1 ashetty1 changed the title Fix PR 811: Should be emptyDir Fix reference to emptyDir in scripts Sep 18, 2017
@ashetty1 ashetty1 changed the title Fix reference to emptyDir in scripts Fix reference to emptyDir in OpenShift test scripts Sep 18, 2017
@cdrage
Copy link
Member

cdrage commented Sep 18, 2017

@ashetty1 I see you updated the GitHub issue, you need to do git commit --amend and fix both the title and description of your commit.

@ashetty1
Fix reference to emptyDir in OpenShift test scripts:
8263958 
From --volumes=empty to --volumes=emptyDir
@cdrage
Copy link
Member

cdrage commented Sep 26, 2017

LGTM

@cdrage cdrage merged commit 8efe274 into kubernetes:master Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel kadel approved these changes

@cdrage cdrage cdrage approved these changes

@surajnarwade surajnarwade surajnarwade approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ashetty1 @kompose-bot @cdrage @kadel @surajnarwade @k8s-ci-robot