Fixed --volumes validation
#817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/XS
|
@surajnarwade, thank you for the pull request! We'll request some people to review your PR. @cdrage and @kadel, please review this. |
k8s-ci-robot
added
the
cncf-cla: yes
cdrage
requested changes
Sep 14, 2017
pkg/app/app.go
Outdated
| @@ -76,6 +76,9 @@ func ValidateFlags(bundle string, args []string, cmd *cobra.Command, opt *kobjec | |||
| replicationController := cmd.Flags().Lookup("replication-controller").Changed | |||
| deployment := cmd.Flags().Lookup("deployment").Changed | |||
|
|
|||
| //Check volume flag | |||
| volume := cmd.Flags().Lookup("volumes").Value.String() | |||
There was a problem hiding this comment.
No need to do a look up. It's available at opt.Volume
pkg/app/app.go
Outdated
| @@ -133,6 +136,10 @@ func ValidateFlags(bundle string, args []string, cmd *cobra.Command, opt *kobjec | |||
| if opt.GenerateJSON && opt.GenerateYaml { | |||
| log.Fatalf("YAML and JSON format cannot be provided at the same time") | |||
| } | |||
|
|
|||
| if volume != "persistentVolumeClaim" && volume != "emptyDir" { | |||
surajnarwade
force-pushed
the
vol_validation
branch
from
fcef34e
to
6fcd9e5
Compare
|
ref #814 |
kadel
approved these changes
Sep 18, 2017
kadel
reviewed
Sep 18, 2017
pkg/app/app.go
Outdated
| @@ -133,6 +133,10 @@ func ValidateFlags(bundle string, args []string, cmd *cobra.Command, opt *kobjec | |||
| if opt.GenerateJSON && opt.GenerateYaml { | |||
| log.Fatalf("YAML and JSON format cannot be provided at the same time") | |||
| } | |||
|
|
|||
| if opt.Volumes != "persistentVolumeClaim" && opt.Volumes != "emptyDir" { | |||
| log.Fatal("Unknown Volume type: ", opt.Volumes) | |||
There was a problem hiding this comment.
Just one small note here. It would be nice if message also showed what values are possible.
surajnarwade
force-pushed
the
vol_validation
branch
from
6fcd9e5
to
166bc93
Compare
cdrage
requested changes
Sep 18, 2017
pkg/app/app.go
Outdated
| @@ -133,6 +133,10 @@ func ValidateFlags(bundle string, args []string, cmd *cobra.Command, opt *kobjec | |||
| if opt.GenerateJSON && opt.GenerateYaml { | |||
| log.Fatalf("YAML and JSON format cannot be provided at the same time") | |||
| } | |||
|
|
|||
| if opt.Volumes != "persistentVolumeClaim" && opt.Volumes != "emptyDir" { | |||
| log.Fatal("Unknown Volume type: ", opt.Volumes, ", Possible values are: persistentVolumeClaim, emptyDir") | |||
There was a problem hiding this comment.
remove capitalization of Possible
change to persistentVolumeClaim and emptyDir
surajnarwade
force-pushed
the
vol_validation
branch
from
166bc93
to
ffcc658
Compare
|
@cdrage done |
|
@surajnarwade Please add description to commit. |
surajnarwade
force-pushed
the
vol_validation
branch
2 times, most recently
from
fdbe867
to
613cd6c
Compare
|
issue is being tracked here #814 |
|
@surajnarwade can you add a test? unit / cli test (make sure it fails if someone puts --volumes=foobar or something) |
Now, `--volumes` argument will validate it's input, it will only allow `persistentVolumeClaim` or `emptyDir`, otherwise it will throw an error.
surajnarwade
force-pushed
the
vol_validation
branch
from
613cd6c
to
269f604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.