Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional Testing for kompose cmdline #89

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

surajssd
Copy link
Member

@surajssd surajssd commented Aug 6, 2016

Shell scripts to test k8s and os conversion

@ngtuna
Copy link
Contributor

ngtuna commented Aug 6, 2016

Super! Thanks @surajssd for the patch.

@ngtuna ngtuna closed this Aug 6, 2016
@ngtuna ngtuna reopened this Aug 6, 2016
@ngtuna
Copy link
Contributor

ngtuna commented Aug 7, 2016

@surajssd I ran the test by executing test/cmd/tests.sh and got fails look similar this one:

===> Starting test <===
convert::expect_success_and_warning: Running: 'kompose convert --stdout -f /home/tuna/workspace/gocode-kompose/src/github.com/skippbox/kompose/test/fixtures/etherpad/docker-compose.yml' expected_output: '/home/tuna/workspace/gocode-kompose/src/github.com/skippbox/kompose/test/fixtures/etherpad/output-k8s.json' expected_warning: 'Unsupported key depends_on - ignoring'
jq: Unknown option --argfile
Use jq --help for help with command-line options,
or see the jq documentation at http://stedolan.github.com/jq
FAIL: converted output does not match

Also note: jq is prerequisite. We should mention it in README.

@ngtuna
Copy link
Contributor

ngtuna commented Aug 7, 2016

Also, could you move test/ to script's subfolder ? Thanks.

@surajssd
Copy link
Member Author

surajssd commented Aug 7, 2016

@ngtuna I am using jq - commandline JSON processor [version 1.5] what version are you using?

@ngtuna
Copy link
Contributor

ngtuna commented Aug 7, 2016

@surajssd mine is jq 1.3 (latest on ubuntu 14.04). So it needs jq 1.5. If you mention this requirement in test/README.md then we should be good.

@surajssd
Copy link
Member Author

surajssd commented Aug 8, 2016

I have moved this under script directory.

@ngtuna ngtuna added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2016
Shell scripts to test k8s and os conversion
which can be ran by following command in root dir
`./script/test/cmd/tests.sh`
@surajssd surajssd merged commit aaa94d7 into kubernetes:master Aug 8, 2016
@surajssd surajssd mentioned this pull request Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants