Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image build path error #946

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Fix image build path error #946

merged 1 commit into from
Feb 27, 2018

Conversation

hangyan
Copy link
Contributor

@hangyan hangyan commented Feb 23, 2018 •
edited
Loading

should fix #944

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 23, 2018
@hangyan
Copy link
Contributor Author

hangyan commented Feb 23, 2018

@cdrage Can't get enough information about why semaphoreci would failed

@cdrage
Copy link
Member

cdrage commented Feb 23, 2018

Hate asking, but any way to add a test? 😄

The SemaphoreCI error (OpenShift) is a false positive.

@hangyan
Copy link
Contributor Author

hangyan commented Feb 23, 2018

@cdrage my apologize, not familiar with the tests for now, i will figure it out and add some tests.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2018
@hangyan
Copy link
Contributor Author

hangyan commented Feb 24, 2018

@cdrage tests added. Please take a look

@cdrage
Copy link
Member

cdrage commented Feb 27, 2018 •
edited
Loading

Thanks again @hangyan this works and tests are great 💯 Merging!

@cdrage cdrage merged commit 47a8bfc into kubernetes:master Feb 27, 2018
@hangyan hangyan deleted the fix-build-path branch March 31, 2018 04:05
@akin-ozer akin-ozer mentioned this pull request Mar 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kompose doesn't find dockerfile with context .
3 participants
@hangyan @cdrage @k8s-ci-robot