support share cores with numa binding #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #554 +/- ##
==========================================
- Coverage 56.51% 56.45% -0.07%
==========================================
Files 543 544 +1
Lines 50984 51117 +133
==========================================
+ Hits 28815 28857 +42
- Misses 18500 18597 +97
+ Partials 3669 3663 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cheney-lin
reviewed
Apr 22, 2024
pkg/agent/qrm-plugins/cpu/dynamicpolicy/cpueviction/strategy/pressure_load.go
Outdated
Show resolved
Hide resolved
pkg/agent/sysadvisor/plugin/qosaware/resource/cpu/isolation/isolator_load.go
Outdated
Show resolved
Hide resolved
cheney-lin
reviewed
Apr 23, 2024
...ent/sysadvisor/plugin/qosaware/resource/cpu/assembler/provisionassembler/assembler_common.go
Outdated
Show resolved
Hide resolved
nightmeng
force-pushed
the
dev/support-share-cores-with-numa-binding
branch
5 times, most recently
from
2d0cbb6
to
b3b92d3
Compare
|
what's the difference between this pr and #481 ? |
nightmeng
force-pushed
the
dev/support-share-cores-with-numa-binding
branch
2 times, most recently
from
8158cad
to
174d02a
Compare
nightmeng
force-pushed
the
dev/support-share-cores-with-numa-binding
branch
9 times, most recently
from
7cf0e11
to
004c298
Compare
pkg/agent/qrm-plugins/cpu/dynamicpolicy/cpueviction/strategy/pressure_load.go
Outdated
Show resolved
Hide resolved
nightmeng
changed the title
nightmeng
force-pushed
the
dev/support-share-cores-with-numa-binding
branch
3 times, most recently
from
77461c7
to
265b60c
Compare
nightmeng
force-pushed
the
dev/support-share-cores-with-numa-binding
branch
from
265b60c
to
8892f66
Compare
nightmeng
force-pushed
the
dev/support-share-cores-with-numa-binding
branch
6 times, most recently
from
bb2dfd3
to
84196c1
Compare
nightmeng
force-pushed
the
dev/support-share-cores-with-numa-binding
branch
from
84196c1
to
53bec7b
Compare
csfldf
approved these changes
Jun 12, 2024
cheney-lin
approved these changes
Jun 12, 2024
waynepeking348
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features
What this PR does / why we need it:
Support share cores with NUMA binding
Which issue(s) this PR fixes:
Special notes for your reviewer: