Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spd): support ihpa #630

Merged
merged 1 commit into from
Jul 10, 2024
Merged

feat(spd): support ihpa #630

merged 1 commit into from
Jul 10, 2024

Conversation

kapybar4
Copy link
Contributor

@kapybar4 kapybar4 commented Jun 17, 2024

What type of PR is this?

Features

What this PR does / why we need it:

Intelligent HPA is used to provide richer and more powerful HPA capabilities. The current core capability is to achieve intelligent elastic scaling of workloads based on workload prediction data generated by resource portraits.
IHPA is mainly composed of Controller and Metrics Adapter.
Controller tuning mainly involves 4 resource objects:

  • Workload, the controller will add SPD Annotation to the workload associated with IHPA. Currently, only Deployment and StatefulSet are supported.
  • HPA, the controller automatically creates and refreshes HPA based on IHPA.
  • Virtual workload, the Scale object used by IHPA to implement observation mode, will be referenced by the workload written to HPA.
  • SPD, the controller will write the Resource Portrait algorithm configuration defined in IHPA to SPD, and then the Resource Portrait plug-in will refresh the workload prediction data.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 51.52979% with 301 lines in your changes missing coverage. Please review.

Project coverage is 56.89%. Comparing base (aaa141b) to head (bb6fbbd).

Files Patch % Lines
pkg/controller/ihpa/ihpa.go 22.22% 186 Missing and 3 partials ⚠️
...roller/spd/indicator-plugin/plugins/ihpa/plugin.go 0.00% 42 Missing ⚠️
pkg/controller/ihpa/util.go 83.00% 16 Missing and 10 partials ⚠️
...ugin/plugins/resource-portrait/indicator_plugin.go 17.64% 14 Missing ⚠️
pkg/custom-metric/store/custom/spd_metric_store.go 72.34% 7 Missing and 6 partials ⚠️
pkg/client/control/ihpa.go 81.13% 5 Missing and 5 partials ⚠️
cmd/katalyst-controller/app/options/ihpa.go 50.00% 6 Missing ⚠️
cmd/katalyst-controller/app/options/controller.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
+ Coverage   56.79%   56.89%   +0.10%     
==========================================
  Files         545      552       +7     
  Lines       51975    52574     +599     
==========================================
+ Hits        29517    29910     +393     
- Misses      18737    18918     +181     
- Partials     3721     3746      +25     
Flag Coverage Δ
unittest 56.89% <51.52%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kapybar4 kapybar4 force-pushed the feat-ihpa branch 10 times, most recently from 28dd046 to 2b81a98 Compare June 24, 2024 11:37
@luomingmeng luomingmeng added the workflow/need-review review: test succeeded, need to review label Jun 25, 2024
@luomingmeng luomingmeng added this to the v0.5 milestone Jun 25, 2024
@kapybar4 kapybar4 force-pushed the feat-ihpa branch 3 times, most recently from 849b20d to 8860501 Compare June 26, 2024 02:07
@caohe caohe requested a review from WangZzzhe June 26, 2024 03:10
@kapybar4 kapybar4 force-pushed the feat-ihpa branch 7 times, most recently from 812cc7e to 21532e0 Compare July 3, 2024 04:55
WangZzzhe
WangZzzhe previously approved these changes Jul 5, 2024
caohe
caohe previously approved these changes Jul 5, 2024
@luomingmeng luomingmeng merged commit 62045cf into kubewharf:main Jul 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/need-review review: test succeeded, need to review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants