Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sysadvisor): fix isolacted size calculated incorrectly #656

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

cheney-lin
Copy link
Member

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.89%. Comparing base (29d4745) to head (0807cf1).
Report is 5 commits behind head on main.

Files Patch % Lines
...u/assembler/provisionassembler/assembler_common.go 80.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   57.00%   56.89%   -0.11%     
==========================================
  Files         552      553       +1     
  Lines       52838    53177     +339     
==========================================
+ Hits        30118    30257     +139     
- Misses      18941    19127     +186     
- Partials     3779     3793      +14     
Flag Coverage Δ
unittest 56.89% <80.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheney-lin cheney-lin self-assigned this Jul 22, 2024
@cheney-lin cheney-lin added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Jul 22, 2024
@cheney-lin cheney-lin force-pushed the fix/pool_size branch 4 times, most recently from 3ae040c to 646e85d Compare July 24, 2024 07:04
…are pool not existed

Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
@xu282934741 xu282934741 merged commit df45505 into kubewharf:main Jul 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants