refine pressure_supression eviction and getUtilBasedHeadroom #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheney-lin
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
==========================================
- Coverage 56.84% 56.78% -0.07%
==========================================
Files 553 554 +1
Lines 53165 53185 +20
==========================================
- Hits 30224 30203 -21
- Misses 19138 19191 +53
+ Partials 3803 3791 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cheney-lin
force-pushed
the
dev/refine_util_based
branch
2 times, most recently
from
c30a552
to
5204558
Compare
when allow_shared_cores_overlap_reclaimed = true, the workloads of reclaim pool include shared_cores and reclaimed_cores, so resource supply for reclaimed_cores should consider shared_cores. Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
when allow_shared_cores_overlap_reclaimed = true, the workloads of reclaim pool include shared_cores and reclaimed_cores, so actual resource supply for reclaimed_cores should be idle of pool plus reclaim usage, so GetEvictPods of pressure_supression is adapated here. Signed-off-by: linzhecheng <linzhecheng@bytedance.com>
cheney-lin
force-pushed
the
dev/refine_util_based
branch
from
5204558
to
3f4179f
Compare
nightmeng
approved these changes
Jul 30, 2024
csfldf
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancements
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: